[Obs AI Assistant] Fix alerts function #203695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
viduni94
added
release_note:skip
viduni94
force-pushed
the
fix-issue-with-alerts-function
branch
from
0382919 to
29beae1
Compare
viduni94
added
release_note:fix
and removed
release_note:skip
viduni94
force-pushed
the
fix-issue-with-alerts-function
branch
from
29beae1 to
71b81e4
Compare
|
LGTM |
arturoliduena
approved these changes
Dec 10, 2024
…hat the query is correct (elastic#203458)
viduni94
commented
Dec 11, 2024
| @@ -137,57 +137,6 @@ export default function ApiTest({ getService }: FtrProviderContext) { | |||
| ]); | |||
| }); | |||
|
|
|||
| it.skip('returns a useful error if the request fails', async () => { | |||
There was a problem hiding this comment.
Removed in favour of https://github.com/elastic/kibana/pull/199286/files#r1868828826
⏳ Build in-progress
History
cc @viduni94 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
## Summary ### Problem With the merge of the PR elastic#183756, the alerts function has stopped working in the Obs AI Assistant, because there has been a change to the query (when finding alerts) ### Solution Revert the change made to the query. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit d9c1cd3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Fix alerts function (#203695)](#203695) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T15:25:36Z","message":"[Obs AI Assistant] Fix alerts function (#203695)\n\n## Summary\r\n\r\n### Problem\r\nWith the merge of the PR https://github.com/elastic/kibana/pull/183756,\r\nthe alerts function has stopped working in the Obs AI Assistant, because\r\nthere has been a change to the query (when finding alerts)\r\n\r\n### Solution\r\nRevert the change made to the query.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9c1cd30af82abf12b5d569cbaa8886fbb78a5bb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Fix alerts function","number":203695,"url":"https://github.com/elastic/kibana/pull/203695","mergeCommit":{"message":"[Obs AI Assistant] Fix alerts function (#203695)\n\n## Summary\r\n\r\n### Problem\r\nWith the merge of the PR https://github.com/elastic/kibana/pull/183756,\r\nthe alerts function has stopped working in the Obs AI Assistant, because\r\nthere has been a change to the query (when finding alerts)\r\n\r\n### Solution\r\nRevert the change made to the query.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9c1cd30af82abf12b5d569cbaa8886fbb78a5bb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203695","number":203695,"mergeCommit":{"message":"[Obs AI Assistant] Fix alerts function (#203695)\n\n## Summary\r\n\r\n### Problem\r\nWith the merge of the PR https://github.com/elastic/kibana/pull/183756,\r\nthe alerts function has stopped working in the Obs AI Assistant, because\r\nthere has been a change to the query (when finding alerts)\r\n\r\n### Solution\r\nRevert the change made to the query.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9c1cd30af82abf12b5d569cbaa8886fbb78a5bb"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary ### Problem With the merge of the PR elastic#183756, the alerts function has stopped working in the Obs AI Assistant, because there has been a change to the query (when finding alerts) ### Solution Revert the change made to the query. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
With the merge of the PR #183756, the alerts function has stopped working in the Obs AI Assistant, because there has been a change to the query (when finding alerts)
Solution
Revert the change made to the query.
Checklist
release_note:*label is applied per the guidelines