Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Import] Use datastream description in readme #203236

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Dec 6, 2024

Release note

Use provided data stream description in generated README

Summary

Closes #201294

This PR fixes use of datastream description that the user entered in the input field.

image

@bhapas bhapas requested a review from a team as a code owner December 6, 2024 13:05
@bhapas bhapas self-assigned this Dec 6, 2024
@bhapas bhapas added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Security-Scalability Team label for Security Integrations Scalability Team backport:version Backport to applied version labels Feature:AutomaticImport labels Dec 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 9, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / buildPackage Should call createReadme once with sorted fields
  • [job] [logs] Jest Tests #3 / buildPackage Should call createReadme once with sorted fields

Metrics [docs]

✅ unchanged

History

cc @bhapas

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhapas bhapas merged commit d3161ab into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12250708665

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
## Release note

Use provided data stream description in generated README

## Summary

Closes [elastic#201294](elastic#201294)

This PR fixes use of `datastream description` that the user entered in
the input field.

![image](https://github.com/user-attachments/assets/b093c978-2102-4bdc-824e-d60aa3fd908b)

(cherry picked from commit d3161ab)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
… (#203516)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import] Use datastream description in readme
(#203236)](#203236)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T06:32:22Z","message":"[Automatic
Import] Use datastream description in readme (#203236)\n\n## Release
note\r\n\r\nUse provided data stream description in generated
README\r\n\r\n## Summary\r\n\r\nCloses
[#201294](https://github.com/elastic/kibana/issues/201294)\r\n\r\nThis
PR fixes use of `datastream description` that the user entered in\r\nthe
input
field.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/b093c978-2102-4bdc-824e-d60aa3fd908b)","sha":"d3161abc38f47284e5aaa41590ef89f8b78f28f3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","Team:Security-Scalability","backport:version","Feature:AutomaticImport"],"title":"[Automatic
Import] Use datastream description in
readme","number":203236,"url":"https://github.com/elastic/kibana/pull/203236","mergeCommit":{"message":"[Automatic
Import] Use datastream description in readme (#203236)\n\n## Release
note\r\n\r\nUse provided data stream description in generated
README\r\n\r\n## Summary\r\n\r\nCloses
[#201294](https://github.com/elastic/kibana/issues/201294)\r\n\r\nThis
PR fixes use of `datastream description` that the user entered in\r\nthe
input
field.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/b093c978-2102-4bdc-824e-d60aa3fd908b)","sha":"d3161abc38f47284e5aaa41590ef89f8b78f28f3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203236","number":203236,"mergeCommit":{"message":"[Automatic
Import] Use datastream description in readme (#203236)\n\n## Release
note\r\n\r\nUse provided data stream description in generated
README\r\n\r\n## Summary\r\n\r\nCloses
[#201294](https://github.com/elastic/kibana/issues/201294)\r\n\r\nThis
PR fixes use of `datastream description` that the user entered in\r\nthe
input
field.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/b093c978-2102-4bdc-824e-d60aa3fd908b)","sha":"d3161abc38f47284e5aaa41590ef89f8b78f28f3"}}]}]
BACKPORT-->

Co-authored-by: Bharat Pasupula <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Release note

Use provided data stream description in generated README

## Summary

Closes [elastic#201294](elastic#201294)

This PR fixes use of `datastream description` that the user entered in
the input field.


![image](https://github.com/user-attachments/assets/b093c978-2102-4bdc-824e-d60aa3fd908b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels Feature:AutomaticImport release_note:fix Team:Security-Scalability Team label for Security Integrations Scalability Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Automatic Import] Use provided data stream description in generated README
4 participants