Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725) #202907

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[8.x] [ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725) #202907

merged 2 commits into from
Dec 4, 2024

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Dec 4, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@Zacqary
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-…
303fa0a 
…form (elastic#198725)

## Summary

Part of elastic#195211

Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new
package called `@kbn/response-ops-rule-form`.

Some types and hooks that are used by multiple features or solutions are
still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of
Rule Form-specific code is in this new package.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kevin Delemme <[email protected]>
(cherry picked from commit 8f267fd)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/plugins/translations/translations/zh-CN.json
@Zacqary Zacqary enabled auto-merge (squash) December 4, 2024 12:52
@Zacqary Zacqary mentioned this pull request Dec 4, 2024
Merged
1 task
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Dec 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cnasikas cnasikas disabled auto-merge December 4, 2024 20:34
@cnasikas cnasikas force-pushed the backport/8.x/pr-198725 branch from c0dd573 to 303fa0a Compare December 4, 2024 20:35
@cnasikas
Copy link
Member

cnasikas commented Dec 4, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@cnasikas cnasikas enabled auto-merge (squash) December 4, 2024 20:43
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 128b3c0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202907-128b3c06facc

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alerting 244 242 -2
observability 1075 1073 -2
securitySolution 6300 6298 -2
triggersActionsUi 858 866 +8
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerts-ui-shared 295 286 -9
@kbn/response-ops-rule-form - 156 +156
@kbn/triggers-actions-ui-types 15 17 +2
total +149

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 89.9KB 98.3KB +8.5KB
cases 492.7KB 492.7KB +20.0B
observability 472.5KB 481.1KB +8.5KB
securitySolution 13.4MB 13.4MB +8.5KB
triggersActionsUi 1.7MB 1.7MB +13.9KB
total +39.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/alerts-ui-shared 8 4 -4
@kbn/response-ops-rule-form - 7 +7
total +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 25.5KB 25.5KB +56.0B
triggersActionsUi 128.5KB 127.0KB -1.4KB
total -1.4KB
Unknown metric groups

API count

id before after diff
@kbn/alerts-ui-shared 311 302 -9
@kbn/response-ops-rule-form - 157 +157
@kbn/triggers-actions-ui-types 15 17 +2
total +150

ESLint disabled line counts

id before after diff
@kbn/alerts-ui-shared 8 5 -3
@kbn/response-ops-rule-form - 4 +4
total +1

References to deprecated APIs

id before after diff
@kbn/alerts-ui-shared 8 0 -8
@kbn/response-ops-rule-form - 8 +8
total -0

Total ESLint disabled count

id before after diff
@kbn/alerts-ui-shared 9 6 -3
@kbn/response-ops-rule-form - 4 +4
total +1

History

@cnasikas cnasikas merged commit 4beeb72 into elastic:8.x Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zacqary @elasticmachine @cnasikas