Replace style with css prop in SessionView plugin
#202778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertoblaz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
|
@albertoblaz Any screenshot to validate none of the styles broke? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @albertoblaz |
maxcold
approved these changes
Jan 13, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Part of the resolution of this issue: - elastic#149246 Removes the `style` prop in React components and elements to avoid using inline styles. Instead, it uses now the `emotion.css` prop to dynamically attach all styles to the native `class` attribute. ### Motivation Using inline styles at scale causes a performance penalty at rendering time. It's way more efficient to attach styles to a single or several classnames instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Maxim Kholod <[email protected]> (cherry picked from commit 0d4ccaf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 13, 2025
…iew plugin (#202778) (#206426) # Backport This will backport the following commits from `main` to `8.x`: - [Replace `style` with `css` prop in SessionView plugin (#202778)](#202778) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-13T12:53:31Z","message":"Replace `style` with `css` prop in SessionView plugin (#202778)\n\n## Summary\r\n\r\nPart of the resolution of this issue: \r\n- https://github.com/elastic/kibana/issues/149246\r\n\r\nRemoves the `style` prop in React components and elements to avoid using\r\ninline styles. Instead, it uses now the `emotion.css` prop to\r\ndynamically attach all styles to the native `class` attribute.\r\n\r\n### Motivation\r\n\r\nUsing inline styles at scale causes a performance penalty at rendering\r\ntime. It's way more efficient to attach styles to a single or several\r\nclassnames instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0d4ccaf7b2da0028841eec6678fd20351d6e3303","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","backport:version","v8.18.0"],"title":"Replace `style` with `css` prop in SessionView plugin","number":202778,"url":"https://github.com/elastic/kibana/pull/202778","mergeCommit":{"message":"Replace `style` with `css` prop in SessionView plugin (#202778)\n\n## Summary\r\n\r\nPart of the resolution of this issue: \r\n- https://github.com/elastic/kibana/issues/149246\r\n\r\nRemoves the `style` prop in React components and elements to avoid using\r\ninline styles. Instead, it uses now the `emotion.css` prop to\r\ndynamically attach all styles to the native `class` attribute.\r\n\r\n### Motivation\r\n\r\nUsing inline styles at scale causes a performance penalty at rendering\r\ntime. It's way more efficient to attach styles to a single or several\r\nclassnames instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0d4ccaf7b2da0028841eec6678fd20351d6e3303"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202778","number":202778,"mergeCommit":{"message":"Replace `style` with `css` prop in SessionView plugin (#202778)\n\n## Summary\r\n\r\nPart of the resolution of this issue: \r\n- https://github.com/elastic/kibana/issues/149246\r\n\r\nRemoves the `style` prop in React components and elements to avoid using\r\ninline styles. Instead, it uses now the `emotion.css` prop to\r\ndynamically attach all styles to the native `class` attribute.\r\n\r\n### Motivation\r\n\r\nUsing inline styles at scale causes a performance penalty at rendering\r\ntime. It's way more efficient to attach styles to a single or several\r\nclassnames instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0d4ccaf7b2da0028841eec6678fd20351d6e3303"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alberto Blázquez <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Part of the resolution of this issue: - elastic#149246 Removes the `style` prop in React components and elements to avoid using inline styles. Instead, it uses now the `emotion.css` prop to dynamically attach all styles to the native `class` attribute. ### Motivation Using inline styles at scale causes a performance penalty at rendering time. It's way more efficient to attach styles to a single or several classnames instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Maxim Kholod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the resolution of this issue:
stylewithemotion.css#149246Removes the
styleprop in React components and elements to avoid using inline styles. Instead, it uses now theemotion.cssprop to dynamically attach all styles to the nativeclassattribute.Motivation
Using inline styles at scale causes a performance penalty at rendering time. It's way more efficient to attach styles to a single or several classnames instead.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines