Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[product documentation] Fix index names #202265

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Nov 29, 2024

Summary

Follow-up of #194379.

Turns out, the prefix for kibana system indices is .kibana_*, so our indices were not considered as kibana system indices and causing warnings when created, such as

Elasticsearch deprecation: 299 Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 "index name [.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices"
Origin:kibana

This PR addresses it, by changing the product doc index names to follow our system index pattern.

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added bug Fixes for quality problems that affect the customer experience Team:AI Infra AppEx AI Infrastructure Team Feature:AI Product Docs Product Documentation for AI workflows release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v8.18.0 and removed v8.18.0 labels Nov 29, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@pgayvallet pgayvallet marked this pull request as ready for review November 29, 2024 11:58
@pgayvallet pgayvallet requested a review from a team as a code owner November 29, 2024 11:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

@pgayvallet pgayvallet added v8.18.0 backport:version Backport to applied version labels labels Nov 29, 2024
@delanni
Copy link
Contributor

delanni commented Nov 29, 2024

admin-merging as per authors request

@delanni delanni merged commit d5cf0a6 into elastic:main Nov 29, 2024
26 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12085675168

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2024
## Summary

Follow-up of elastic#194379.

Turns out, the prefix for kibana system indices is `.kibana_*`, so our
indices were not considered as kibana system indices and causing
warnings when created, such as

```
Elasticsearch deprecation: 299 Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 "index name [.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices"
Origin:kibana
```

This PR addresses it, by changing the product doc index names to follow
our system index pattern.

(cherry picked from commit d5cf0a6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2024
## Summary

Follow-up of elastic#194379.

Turns out, the prefix for kibana system indices is `.kibana_*`, so our
indices were not considered as kibana system indices and causing
warnings when created, such as

```
Elasticsearch deprecation: 299 Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 "index name [.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices"
Origin:kibana
```

This PR addresses it, by changing the product doc index names to follow
our system index pattern.

(cherry picked from commit d5cf0a6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 29, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [[product documentation] Fix index names
(#202265)](#202265)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T13:33:17Z","message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:version","Team:AI
Infra","v8.17.0","v8.18.0","Feature:AI Product Docs"],"title":"[product
documentation] Fix index
names","number":202265,"url":"https://github.com/elastic/kibana/pull/202265","mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202265","number":202265,"mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 29, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[product documentation] Fix index names
(#202265)](#202265)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T13:33:17Z","message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:version","Team:AI
Infra","v8.17.0","v8.18.0","Feature:AI Product Docs"],"title":"[product
documentation] Fix index
names","number":202265,"url":"https://github.com/elastic/kibana/pull/202265","mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202265","number":202265,"mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Follow-up of elastic#194379.

Turns out, the prefix for kibana system indices is `.kibana_*`, so our
indices were not considered as kibana system indices and causing
warnings when created, such as

```
Elasticsearch deprecation: 299 Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 "index name [.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices"
Origin:kibana
```

This PR addresses it, by changing the product doc index names to follow
our system index pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience Feature:AI Product Docs Product Documentation for AI workflows release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants