Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): eui submodule paths in ui-shared-deps-* #202056

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
328871a
fix(NA): cache missing entrypoint
mistic Nov 26, 2024
25b9c23
fix(NA): remove all cached src deps
mistic Dec 2, 2024
6c3769b
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 2, 2024
eb63aa6
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 5, 2024
6d5344c
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 6, 2024
107983c
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 11, 2024
0148ca7
fix(NA): remove unused eui exports
mistic Dec 11, 2024
6db3f36
chore(NA): rearrange theme borealis order
mistic Dec 11, 2024
b0c3c01
chore(NA): cache theme-warning
mistic Dec 11, 2024
048504c
fix(NA): update limits
mistic Dec 11, 2024
58c9c2f
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 12, 2024
4ae4fe5
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 12, 2024
823bd73
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 12, 2024
9c8e358
chore(NA): remove unused extra comments
mistic Dec 12, 2024
81fb316
chore(NA): re-cache again react/kibana_context/theme
mistic Dec 12, 2024
6ec2b91
fix(NA): restore previous optimizer limits
mistic Dec 12, 2024
ba4acf2
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 12, 2024
bc4f139
fix(NA): update limits
mistic Dec 13, 2024
afbf6d6
Merge branch 'test-fix-theme-loader-shared-deps' of github.com:mistic…
mistic Dec 13, 2024
207549a
fix(NA): update limits
mistic Dec 13, 2024
49a3581
fix(NA): update limits
mistic Dec 13, 2024
864e9e7
Merge remote-tracking branch 'upstream/main' into test-fix-theme-load…
mistic Dec 14, 2024
ffb7a59
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 16, 2024
f649a1f
Merge remote-tracking branch 'upstream/main' into test-fix-theme-load…
mistic Dec 19, 2024
96a0c84
Merge branch 'main' into test-fix-theme-loader-shared-deps
mistic Dec 23, 2024
4f9a4b1
chore(NA): experiment not to cache react kibana context theme
mistic Dec 23, 2024
d5e5f98
fix(NA): test uncomment eui provider dev warning
mistic Dec 24, 2024
3d2f6d3
Revert "fix(NA): test uncomment eui provider dev warning"
mistic Dec 24, 2024
1567601
Revert "chore(NA): experiment not to cache react kibana context theme"
mistic Dec 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pageLoadAssetSize:
dataUsage: 30000
dataViewEditor: 28082
dataViewFieldEditor: 42021
dataViewManagement: 5370
dataViewManagement: 5500
dataViews: 65000
dataVisualizer: 30000
devTools: 38637
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-ui-shared-deps-npm/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ module.exports = (_, argv) => {
'@elastic/charts',
'@elastic/eui',
'@elastic/eui/optimize/es/components/provider/nested',
'@elastic/eui/optimize/es/services',
'@elastic/eui/optimize/es/services/format',
'@elastic/eui/optimize/es/services/theme/warning',
'@elastic/eui/dist/eui_theme_amsterdam_light.json',
'@elastic/eui/dist/eui_theme_amsterdam_dark.json',
'@elastic/eui/dist/eui_theme_borealis_light.json',
'@elastic/eui/dist/eui_theme_borealis_dark.json',
'@elastic/eui-theme-borealis',
'@elastic/numeral',
'@emotion/cache',
'@emotion/react',
Expand Down
3 changes: 1 addition & 2 deletions packages/kbn-ui-shared-deps-src/src/definitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ const externals = {
'@elastic/eui': '__kbnSharedDeps__.ElasticEui',
'@elastic/eui/lib/components/provider/nested':
'__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider',
'@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices',
'@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat',
'@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning',
'@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis',

// transient dep of eui
Expand Down
5 changes: 2 additions & 3 deletions packages/kbn-ui-shared-deps-src/src/entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,9 @@ export const Rxjs = require('rxjs');
export const ElasticNumeral = require('@elastic/numeral');
export const ElasticCharts = require('@elastic/charts');
export const ElasticEui = require('@elastic/eui');
export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis');
export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested');
export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services');
export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format');
export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning');
export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis');
export const KbnDatemath = require('@kbn/datemath');
export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd');
export const ReduxjsToolkit = require('@reduxjs/toolkit');
Expand Down
3 changes: 3 additions & 0 deletions packages/kbn-ui-shared-deps-src/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ module.exports = {
extensions: ['.js', '.ts', '.tsx'],
alias: {
'@elastic/eui$': '@elastic/eui/optimize/es',
'@elastic/eui/lib/components/provider/nested$':
'@elastic/eui/optimize/es/components/provider/nested',
'@elastic/eui/lib/services/theme/warning$': '@elastic/eui/optimize/es/services/theme/warning',
moment: MOMENT_SRC,
// NOTE: Used to include react profiling on bundles
// https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977#webpack-4
Expand Down