Reorganize references to folders owned by CSP team in CODEOWNERS file
#202036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Entire folder is owned by kibana-cloud-security-posture
albertoblaz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
albertoblaz
added
the
backport:prev-minor
acorretti
approved these changes
Nov 27, 2024
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
cc @albertoblaz |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@albertoblaz I think we can skip backporting the codeowners file as codeowners it's only used in the main branch |
opauloh
removed
backport missing
|
I removed the backport labels |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…le (elastic#202036) ## Summary Reorganize references to folders owned by the CSP team in `CODEOWNERS` file. ### Details - Removed duplicated reference to `x-pack/plugins/security_solution/public/cloud_security_posture` folder - Removed redundant references to `basic.ts` and `essentials.ts` in `x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture` folder when whole of it is owned - ~~Removed redundant references to `common`, `graph` and `public` folders in CSP package when whole package is owned (and missed an explicit reference to the `storybook` subfolder too)~~ - ~~Grouped and sorted references to all folders owned by our team to avoid spreading them and to have them in a single part of the file~~ CI autogenerates part of the file, so I could only group and sort some references ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reorganize references to folders owned by the CSP team in
CODEOWNERSfile.Details
x-pack/plugins/security_solution/public/cloud_security_posturefolderbasic.tsandessentials.tsinx-pack/test_serverless/functional/test_suites/security/config.cloud_security_posturefolder when whole of it is ownedRemoved redundant references tocommon,graphandpublicfolders in CSP package when whole package is owned (and missed an explicit reference to thestorybooksubfolder too)Grouped and sorted references to all folders owned by our team to avoid spreading them and to have them in a single part of the fileCI autogenerates part of the file, so I could only group and sort some referencesChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines