[Logs] Deprecate HTTP APIs used in LogStream app #201974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
tonyghiani
changed the title
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
## 📓 Summary Closes elastic#200968 These changes deprecate internal APIs used by the LogStream app, which is also deprecated. With v9, any internal API will become unreachable from external origins. In case we get an external request to these APIs (although it should be less likely to happen), the deprecation will be surfaced on the Upgrade Assistant UI as a warning. <img width="3005" alt="Screenshot 2024-11-27 at 13 16 39" src="https://github.com/user-attachments/assets/c3864a5a-49c7-4cbd-8893-9041b5ee207e"> <img width="3007" alt="Screenshot 2024-11-27 at 13 16 25" src="https://github.com/user-attachments/assets/f9fb254f-b795-4d01-8d92-463a0ca526a3"> Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit a176c0f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
…3748) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Deprecate HTTP APIs used in LogStream app (#201974)](#201974) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T10:41:28Z","message":"[Logs] Deprecate HTTP APIs used in LogStream app (#201974)\n\n## 📓 Summary\r\n\r\nCloses #200968 \r\n\r\nThese changes deprecate internal APIs used by the LogStream app, which\r\nis also deprecated.\r\n\r\nWith v9, any internal API will become unreachable from external origins.\r\nIn case we get an external request to these APIs (although it should be\r\nless likely to happen), the deprecation will be surfaced on the Upgrade\r\nAssistant UI as a warning.\r\n\r\n<img width=\"3005\" alt=\"Screenshot 2024-11-27 at 13 16 39\"\r\nsrc=\"https://github.com/user-attachments/assets/c3864a5a-49c7-4cbd-8893-9041b5ee207e\">\r\n\r\n<img width=\"3007\" alt=\"Screenshot 2024-11-27 at 13 16 25\"\r\nsrc=\"https://github.com/user-attachments/assets/f9fb254f-b795-4d01-8d92-463a0ca526a3\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"a176c0fdd7815e5841ed78f5213f1296226b276e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Logs] Deprecate HTTP APIs used in LogStream app","number":201974,"url":"https://github.com/elastic/kibana/pull/201974","mergeCommit":{"message":"[Logs] Deprecate HTTP APIs used in LogStream app (#201974)\n\n## 📓 Summary\r\n\r\nCloses #200968 \r\n\r\nThese changes deprecate internal APIs used by the LogStream app, which\r\nis also deprecated.\r\n\r\nWith v9, any internal API will become unreachable from external origins.\r\nIn case we get an external request to these APIs (although it should be\r\nless likely to happen), the deprecation will be surfaced on the Upgrade\r\nAssistant UI as a warning.\r\n\r\n<img width=\"3005\" alt=\"Screenshot 2024-11-27 at 13 16 39\"\r\nsrc=\"https://github.com/user-attachments/assets/c3864a5a-49c7-4cbd-8893-9041b5ee207e\">\r\n\r\n<img width=\"3007\" alt=\"Screenshot 2024-11-27 at 13 16 25\"\r\nsrc=\"https://github.com/user-attachments/assets/f9fb254f-b795-4d01-8d92-463a0ca526a3\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"a176c0fdd7815e5841ed78f5213f1296226b276e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201974","number":201974,"mergeCommit":{"message":"[Logs] Deprecate HTTP APIs used in LogStream app (#201974)\n\n## 📓 Summary\r\n\r\nCloses #200968 \r\n\r\nThese changes deprecate internal APIs used by the LogStream app, which\r\nis also deprecated.\r\n\r\nWith v9, any internal API will become unreachable from external origins.\r\nIn case we get an external request to these APIs (although it should be\r\nless likely to happen), the deprecation will be surfaced on the Upgrade\r\nAssistant UI as a warning.\r\n\r\n<img width=\"3005\" alt=\"Screenshot 2024-11-27 at 13 16 39\"\r\nsrc=\"https://github.com/user-attachments/assets/c3864a5a-49c7-4cbd-8893-9041b5ee207e\">\r\n\r\n<img width=\"3007\" alt=\"Screenshot 2024-11-27 at 13 16 25\"\r\nsrc=\"https://github.com/user-attachments/assets/f9fb254f-b795-4d01-8d92-463a0ca526a3\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"a176c0fdd7815e5841ed78f5213f1296226b276e"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## 📓 Summary Closes elastic#200968 These changes deprecate internal APIs used by the LogStream app, which is also deprecated. With v9, any internal API will become unreachable from external origins. In case we get an external request to these APIs (although it should be less likely to happen), the deprecation will be surfaced on the Upgrade Assistant UI as a warning. <img width="3005" alt="Screenshot 2024-11-27 at 13 16 39" src="https://github.com/user-attachments/assets/c3864a5a-49c7-4cbd-8893-9041b5ee207e"> <img width="3007" alt="Screenshot 2024-11-27 at 13 16 25" src="https://github.com/user-attachments/assets/f9fb254f-b795-4d01-8d92-463a0ca526a3"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #200968
These changes deprecate internal APIs used by the LogStream app, which is also deprecated.
With v9, any internal API will become unreachable from external origins. In case we get an external request to these APIs (although it should be less likely to happen), the deprecation will be surfaced on the Upgrade Assistant UI as a warning.