[8.17] [Security Solution] Display cardinality for threshold rules (#201162) #201959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…201162) **Resolves elastic#161576** ## Summary This PR fixes the description of threshold rules. The problem was that if a threshold rule contained 'Count' (cardinality) it wasn't displayed neither in a summary while creating the rule, nor in the rule details page. This PR fixes these two places, introducing similar logic to the two places in the code, to display the cardinality if it is present in the threshold object. ### BEFORE 1. overview page <img width="1027" alt="image" src="https://github.com/user-attachments/assets/b927b4e0-f2a0-41ba-87e0-441a53760cce"> 2. rule details page <img width="762" alt="image" src="https://github.com/user-attachments/assets/486f8616-8582-45ea-9422-bfd554e2ae83"> ### AFTER 1. overview page <img width="1015" alt="image" src="https://github.com/user-attachments/assets/06a5e0d1-76ef-434e-9c1c-cce6c3ff504f"> 2. rule details page <img width="893" alt="image" src="https://github.com/user-attachments/assets/40acd7d4-4058-40c0-aa19-e5f489c53c2c"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed Done: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7474 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7473 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7476 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7477 (cherry picked from commit 19a2ff8)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation