Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slo): Overview Embeddable drilldown actions #201870

Merged
merged 12 commits into from
Dec 3, 2024
Merged

fix(slo): Overview Embeddable drilldown actions #201870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
81a1f93
Change visibility to shared
kdelemme Nov 26, 2024
b261574
Add embeddable-enhanced plugin
kdelemme Nov 26, 2024
15cb895
Implements interfaces for enabling drilldown action
kdelemme Nov 26, 2024
b1ff551
Inline variable
kdelemme Nov 26, 2024
089cf28
Merge branch 'main' into fix/embeddables-drilldown
elasticmachine Nov 27, 2024
2e3039e
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Nov 27, 2024
655dff4
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Nov 27, 2024
725a634
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Nov 27, 2024
a35605d
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Nov 28, 2024
eeabe35
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Dec 2, 2024
a1f7a40
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Dec 2, 2024
51c1d95
Merge branch 'main' into fix/embeddables-drilldown
kdelemme Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/embeddable_enhanced/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@elastic/kibana-presentation"
],
"group": "platform",
"visibility": "private",
"visibility": "shared",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-presentation this PR opens up embeddableEnhanced so that it is used directly from solutions (in this case from o11y SLOs).

Up until now, it was only used from "platform" plugins (e.g. visualizations, dashboard_enhanced, lens, maps).

Are you okay with that transition to "shared"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this makes sense IMO. Solutions are expected to register embeddable types, and some of those will use drilldowns.

"description": "Extends embeddable plugin with more functionality",
"plugin": {
"id": "embeddableEnhanced",
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/observability_solution/slo/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@
"optionalPlugins": [
"cloud",
"discover",
"embeddableEnhanced",
"observabilityAIAssistant",
"security",
"serverless",
"spaces",
"security"
"spaces"
],
"requiredBundles": [
"controls",
Expand Down
Loading
Loading