Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [Search] [Playground] [Bug] Add playground index validation (#201032) #201750

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[8.16] [Search] [Playground] [Bug] Add playground index validation (#201032) #201750

merged 1 commit into from
Nov 26, 2024

Conversation

yansavitski
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@yansavitski
[Search] [Playground] [Bug] Add playground index validation (elastic#…
928f96e 
…201032)

Fix bug when localStorage has invalid index, then playground chat page
opens with empty source.

(cherry picked from commit d99431e)

# Conflicts:
#	x-pack/test_serverless/functional/test_suites/search/search_playground/playground_overview.ts
@yansavitski yansavitski requested a review from a team as a code owner November 26, 2024 10:48
@yansavitski yansavitski enabled auto-merge (squash) November 26, 2024 10:48
@yansavitski yansavitski mentioned this pull request Nov 26, 2024
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchPlayground 265 266 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchPlayground 167.8KB 168.9KB +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchPlayground 7.2KB 7.2KB +1.0B

@yansavitski yansavitski merged commit fd924c2 into elastic:8.16 Nov 26, 2024
24 checks passed
@yansavitski yansavitski deleted the backport/8.16/pr-201032 branch November 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yansavitski @elasticmachine @joemcelroy