[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form #201729

maryam-saeidi · 2024-11-26T09:10:53Z

Summary

Testing CI for #198725

# Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management/api/api.ts

…/kibana into 195211-rule-form-package

…fix'

…/kibana into 195211-rule-form-package

…ckage

This reverts commit 6c6240e.

…l us about

…ckage # Conflicts: # .github/CODEOWNERS

…-fix'

…/kibana into 195211-rule-form-package # Conflicts: # x-pack/plugins/fleet/cypress.config.space_awareness.d.ts # x-pack/plugins/fleet/cypress.config.space_awareness.js

…ckage

…ckage # Conflicts: # packages/response-ops/rule_form/src/rule_actions/rule_actions_system_actions_item.tsx # x-pack/plugins/observability_solution/observability/tsconfig.json # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/system_action_type_form.tsx

elasticmachine · 2024-11-26T09:10:57Z

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

Click to trigger kibana-pull-request for this PR!
Click to trigger kibana-deploy-project-from-pr for this PR!

kibanamachine · 2024-11-26T15:38:31Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7491

[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/1 tests passed.

see run history

kibanamachine · 2024-11-26T16:13:27Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7493

[❌] x-pack/test/functional/apps/dashboard/group1/config.ts: 0/1 tests passed.
[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/1 tests passed.

see run history

kibanamachine · 2024-11-27T10:10:14Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7500

[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/3 tests passed.

see run history

kibanamachine · 2024-11-27T11:14:43Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7506

[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/1 tests passed.

see run history

kibanamachine · 2024-11-27T12:04:04Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7507

[✅] x-pack/test/observability_functional/with_rac_write.config.ts: 3/3 tests passed.

see run history

kibanamachine · 2024-11-27T16:03:50Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7513

[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/3 tests passed.

see run history

elasticmachine · 2024-11-27T16:50:16Z

💔 Build Failed

Buildkite Build
Commit: 544f2bf

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #79 / APM specs correlations failed transactions correlations space with no features disabled navigates to the alerts tab
[job] [logs] FTR Configs #79 / APM specs correlations failed transactions correlations space with no features disabled navigates to the alerts tab
[job] [logs] FTR Configs #102 / ObservabilityApp Observability alerts > Alerts table Filtering Autocompletion works
[job] [logs] FTR Configs #102 / ObservabilityApp Observability alerts > Alerts table Filtering Autocompletion works
[job] [logs] Jest Tests #15 / useColumns check if initial width for the last column does not exist
[job] [logs] Jest Tests #15 / useColumns check if initial width for the last column does not exist
[job] [logs] Jest Tests #15 / useColumns columns should changes the column list when defaultColumns has been updated
[job] [logs] Jest Tests #15 / useColumns columns should changes the column list when defaultColumns has been updated
[job] [logs] Jest Tests #15 / useColumns does not fetch alerts fields if they're overridden through the alertsFields prop
[job] [logs] Jest Tests #15 / useColumns does not fetch alerts fields if they're overridden through the alertsFields prop
[job] [logs] Jest Tests #15 / useColumns onColumnResize
[job] [logs] Jest Tests #15 / useColumns onColumnResize
[job] [logs] Jest Tests #15 / useColumns onResetColumns should restore visible columns defaults
[job] [logs] Jest Tests #15 / useColumns onResetColumns should restore visible columns defaults
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the column details in the storage when onToggleColumn is called
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the column details in the storage when onToggleColumn is called
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the list of columns when on Toggle Columns is called
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the list of columns when on Toggle Columns is called
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the list of visible columns when onToggleColumn is called
[job] [logs] Jest Tests #15 / useColumns onToggleColumns should update the list of visible columns when onToggleColumn is called
[job] [logs] Jest Tests #15 / useColumns visibleColumns hide all columns with onChangeVisibleColumns
[job] [logs] Jest Tests #15 / useColumns visibleColumns hide all columns with onChangeVisibleColumns
[job] [logs] Jest Tests #15 / useColumns visibleColumns should change visibleColumns if provided defaultColumns change
[job] [logs] Jest Tests #15 / useColumns visibleColumns should change visibleColumns if provided defaultColumns change
[job] [logs] Jest Tests #15 / useColumns visibleColumns should populate visibleColumns correctly
[job] [logs] Jest Tests #15 / useColumns visibleColumns should populate visibleColumns correctly
[job] [logs] Jest Tests #15 / useColumns visibleColumns show all columns with onChangeVisibleColumns
[job] [logs] Jest Tests #15 / useColumns visibleColumns show all columns with onChangeVisibleColumns

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`alerting`	248	246	-2
`observability`	1074	1072	-2
`securitySolution`	6259	6257	-2
`triggersActionsUi`	862	870	+8
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/alerts-ui-shared`	304	296	-8
`@kbn/response-ops-rule-form`	-	156	+156
`@kbn/triggers-actions-ui-types`	15	17	+2
total			+150

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alerting`	94.1KB	102.8KB	+8.7KB
`cases`	492.7KB	492.9KB	+257.0B
`observability`	472.7KB	480.8KB	+8.2KB
`securitySolution`	13.3MB	13.4MB	+8.7KB
`triggersActionsUi`	1.7MB	1.7MB	+15.0KB
total			+40.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/alerts-ui-shared`	8	4	-4
`@kbn/response-ops-rule-form`	-	7	+7
total			+3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`alerting`	25.6KB	25.6KB	+56.0B
`triggersActionsUi`	128.8KB	127.6KB	-1.2KB
total			-1.2KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/alerts-ui-shared`	320	312	-8
`@kbn/response-ops-rule-form`	-	157	+157
`@kbn/triggers-actions-ui-types`	15	17	+2
total			+151

ESLint disabled line counts

id	before	after	diff
`@kbn/alerts-ui-shared`	8	6	-2
`@kbn/response-ops-rule-form`	-	4	+4
`ruleRegistry`	2	3	+1
`triggersActionsUi`	131	132	+1
total			+4

References to deprecated APIs

id	before	after	diff
`@kbn/alerts-ui-shared`	8	0	-8
`@kbn/response-ops-rule-form`	-	8	+8
total			-0

Total ESLint disabled count

id	before	after	diff
`@kbn/alerts-ui-shared`	9	7	-2
`@kbn/response-ops-rule-form`	-	4	+4
`ruleRegistry`	4	5	+1
`triggersActionsUi`	137	138	+1
total			+4

History

Zacqary and others added 30 commits October 4, 2024 12:18

Change security solution internal/_find find call to POST

b414b7c

Merge remote-tracking branch 'upstream/main'

a015a44

# Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management/api/api.ts

Initial rule form package migration

ee1c71b

Move use fetch flapping settings back to alerts-ui-shared

fa4f526

Remove missing export

34d9942

Fix API imports

d2a953f

Restore alerts-ui-shared rule types

f7a3caf

Update tsconfig

9f9b58a

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

d9b7e1a

[CI] Auto-commit changed files from 'node scripts/notice'

d6dab95

Fix jest rootDir

2f9211c

Merge branch '195211-rule-form-package' of https://github.com/Zacqary…

df7a742

…/kibana into 195211-rule-form-package

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

4b193da

…fix'

Fix i18n, jest, tsconfig

7f7dbc7

Merge branch '195211-rule-form-package' of https://github.com/Zacqary…

783b901

…/kibana into 195211-rule-form-package

Merge remote-tracking branch 'upstream/main' into 195211-rule-form-pa…

e824df5

…ckage

Fix bad merge of elastic#198036

6c6240e

Revert "Fix bad merge of elastic#198036"

e85e18e

This reverts commit 6c6240e.

i18n fix

d53c2c5

Fix typecheck

2c2d16d

Fix imports

3e2ced4

Fix typecheck

7cf86d0

Commit missing files

2549198

Fix types and i18n

b41dc1f

Fix typecheck

2ad2f42

Fix even more import errors that the typecheck finally decided to tel…

a9769a9

…l us about

Fix jest mock imports

c6222f7

Merge remote-tracking branch 'upstream/main' into 195211-rule-form-pa…

b5f1fe1

…ckage # Conflicts: # .github/CODEOWNERS

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

55c4805

Fix jest config

c7a7145

kibanamachine and others added 10 commits November 20, 2024 18:29

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

ea0fd94

…-fix'

Fix imports and i18n

4b81345

Merge branch '195211-rule-form-package' of https://github.com/Zacqary…

5303bba

…/kibana into 195211-rule-form-package # Conflicts: # x-pack/plugins/fleet/cypress.config.space_awareness.d.ts # x-pack/plugins/fleet/cypress.config.space_awareness.js

Attempt at fixing test

df16744

Unskip autocompletion test

8493f7c

Revert limits change

68e8c28

Merge remote-tracking branch 'upstream/main' into 195211-rule-form-pa…

8c3c9ea

…ckage

Attempt to fix test

35739fd

second attempt

da4012a

maryam-saeidi force-pushed the 195211-rule-form-package branch from aa0afdd to da4012a Compare November 26, 2024 14:50

add console log to check feature Ids

52a63a6

benakansara added 4 commits November 26, 2024 18:21

log suggestions

b1fc9c1

add console log for fields

cbb22c5

update console log

9f95df1

add console log in api

e696876

remove caching

d1dd4c9

benakansara added 2 commits November 27, 2024 16:25

remove context

5d62b19

remove console log

544f2bf

mgiota added ci:build-serverless-image and removed ci:build-serverless-image labels Nov 27, 2024

maryam-saeidi closed this Dec 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form #201729

[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form #201729

maryam-saeidi commented Nov 26, 2024

elasticmachine commented Nov 26, 2024 •

edited

Loading

kibanamachine commented Nov 26, 2024

kibanamachine commented Nov 26, 2024

kibanamachine commented Nov 27, 2024

kibanamachine commented Nov 27, 2024

kibanamachine commented Nov 27, 2024

kibanamachine commented Nov 27, 2024

elasticmachine commented Nov 27, 2024 •

edited

Loading

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form #201729

[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form #201729

Conversation

maryam-saeidi commented Nov 26, 2024

Summary

elasticmachine commented Nov 26, 2024 • edited Loading

kibanamachine commented Nov 26, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7491

kibanamachine commented Nov 26, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7493

kibanamachine commented Nov 27, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7500

kibanamachine commented Nov 27, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7506

kibanamachine commented Nov 27, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7507

kibanamachine commented Nov 27, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7513

elasticmachine commented Nov 27, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

elasticmachine commented Nov 26, 2024 •

edited

Loading

elasticmachine commented Nov 27, 2024 •

edited

Loading