Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] [Search][ES3] Enable Inference Management UI in ES3 (#200109) #201464

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR:
- Enables Inference Management in ES3
- Fixes small issues to make sure it works in ES3.
- Added FTR tests.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [X] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 37a0861)
@kibanamachine kibanamachine merged commit 5d8b8eb into elastic:8.17 Nov 22, 2024
26 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / dashboard app - group 6 dashboard view edit mode shows lose changes warning and loses changes on confirmation when a new vis is added

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2322 2323 +1
searchInferenceEndpoints 103 96 -7
total -6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/doc-links 78 79 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 92.7KB 92.8KB +115.0B
indexManagement 697.4KB 697.4KB +63.0B
lists 145.2KB 145.3KB +115.0B
searchInferenceEndpoints 77.4KB 71.7KB -5.8KB
total -5.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 454.0KB 454.1KB +115.0B
enterpriseSearch 54.2KB 54.5KB +293.0B
searchInferenceEndpoints 5.5KB 6.1KB +621.0B
total +1.0KB
Unknown metric groups

API count

id before after diff
@kbn/doc-links 78 79 +1

miscellaneous assets size

id before after diff
searchInferenceEndpoints 731.9KB 34.8KB -697.1KB

cc @Samiul-TheSoccerFan

kibanamachine added a commit that referenced this pull request Nov 23, 2024
…201496)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search][ES3] Enable Inference Management UI in ES3
(#200109)](#200109)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T19:10:45Z","message":"[Search][ES3]
Enable Inference Management UI in ES3 (#200109)\n\n##
Summary\r\n\r\nThis PR:\r\n- Enables Inference Management in ES3\r\n-
Fixes small issues to make sure it works in ES3.\r\n- Added FTR
tests.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following
conditions. \r\n\r\nReviewers should verify this PR satisfies this list
as well.\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] This was
checked for breaking HTTP API changes, and any breaking\r\nchanges have
been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [X] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"37a0861d28aa3fe9e1a35db0c37aa463226b870b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","ci:project-deploy-elasticsearch","backport:version","v8.17.0","v8.18.0"],"title":"[Search][ES3]
Enable Inference Management UI in
ES3","number":200109,"url":"https://github.com/elastic/kibana/pull/200109","mergeCommit":{"message":"[Search][ES3]
Enable Inference Management UI in ES3 (#200109)\n\n##
Summary\r\n\r\nThis PR:\r\n- Enables Inference Management in ES3\r\n-
Fixes small issues to make sure it works in ES3.\r\n- Added FTR
tests.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following
conditions. \r\n\r\nReviewers should verify this PR satisfies this list
as well.\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] This was
checked for breaking HTTP API changes, and any breaking\r\nchanges have
been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [X] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"37a0861d28aa3fe9e1a35db0c37aa463226b870b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200109","number":200109,"mergeCommit":{"message":"[Search][ES3]
Enable Inference Management UI in ES3 (#200109)\n\n##
Summary\r\n\r\nThis PR:\r\n- Enables Inference Management in ES3\r\n-
Fixes small issues to make sure it works in ES3.\r\n- Added FTR
tests.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following
conditions. \r\n\r\nReviewers should verify this PR satisfies this list
as well.\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] This was
checked for breaking HTTP API changes, and any breaking\r\nchanges have
been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [X] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"37a0861d28aa3fe9e1a35db0c37aa463226b870b"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201464","number":201464,"state":"MERGED","mergeCommit":{"sha":"5d8b8eb46a6e91b3edd5804158924994d1cce70f","message":"[8.17]
[Search][ES3] Enable Inference Management UI in ES3 (#200109)
(#201464)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.17`:\n- [[Search][ES3] Enable Inference Management UI in
ES3\n(#200109)](https://github.com/elastic/kibana/pull/200109)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Samiul\nMonir\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-22T19:10:45Z\",\"message\":\"[Search][ES3]\nEnable
Inference Management UI in ES3
(#200109)\\n\\n##\nSummary\\r\\n\\r\\nThis PR:\\r\\n- Enables Inference
Management in ES3\\r\\n-\nFixes small issues to make sure it works in
ES3.\\r\\n- Added FTR\ntests.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\nCheck the PR satisfies following\nconditions.
\\r\\n\\r\\nReviewers should verify this PR satisfies this list\nas
well.\\r\\n\\r\\n- [X] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [X] This was\nchecked
for breaking HTTP API changes, and any breaking\\r\\nchanges have\nbeen
approved by the breaking-change
committee.\nThe\\r\\n`release_note:breaking` label should be applied in
these\nsituations.\\r\\n- [X]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [X] The PR description includes\nthe
appropriate Release Notes section,\\r\\nand the
correct\n`release_node:*` label is applied
per\nthe\\r\\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"37a0861d28aa3fe9e1a35db0c37aa463226b870b\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Search\",\"ci:project-deploy-elasticsearch\",\"backport:version\",\"v8.17.0\"],\"title\":\"[Search][ES3]\nEnable
Inference Management UI
in\nES3\",\"number\":200109,\"url\":\"https://github.com/elastic/kibana/pull/200109\",\"mergeCommit\":{\"message\":\"[Search][ES3]\nEnable
Inference Management UI in ES3
(#200109)\\n\\n##\nSummary\\r\\n\\r\\nThis PR:\\r\\n- Enables Inference
Management in ES3\\r\\n-\nFixes small issues to make sure it works in
ES3.\\r\\n- Added FTR\ntests.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\nCheck the PR satisfies following\nconditions.
\\r\\n\\r\\nReviewers should verify this PR satisfies this list\nas
well.\\r\\n\\r\\n- [X] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [X] This was\nchecked
for breaking HTTP API changes, and any breaking\\r\\nchanges have\nbeen
approved by the breaking-change
committee.\nThe\\r\\n`release_note:breaking` label should be applied in
these\nsituations.\\r\\n- [X]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [X] The PR description includes\nthe
appropriate Release Notes section,\\r\\nand the
correct\n`release_node:*` label is applied
per\nthe\\r\\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"37a0861d28aa3fe9e1a35db0c37aa463226b870b\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/200109\",\"number\":200109,\"mergeCommit\":{\"message\":\"[Search][ES3]\nEnable
Inference Management UI in ES3
(#200109)\\n\\n##\nSummary\\r\\n\\r\\nThis PR:\\r\\n- Enables Inference
Management in ES3\\r\\n-\nFixes small issues to make sure it works in
ES3.\\r\\n- Added FTR\ntests.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\nCheck the PR satisfies following\nconditions.
\\r\\n\\r\\nReviewers should verify this PR satisfies this list\nas
well.\\r\\n\\r\\n- [X] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [X] This was\nchecked
for breaking HTTP API changes, and any breaking\\r\\nchanges have\nbeen
approved by the breaking-change
committee.\nThe\\r\\n`release_note:breaking` label should be applied in
these\nsituations.\\r\\n- [X]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [X] The PR description includes\nthe
appropriate Release Notes section,\\r\\nand the
correct\n`release_node:*` label is applied
per\nthe\\r\\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"37a0861d28aa3fe9e1a35db0c37aa463226b870b\"}},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Samiul Monir
<[email protected]>"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Samiul Monir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants