[Inventory] Change discover link to use entity definition #201433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
the
Team:obs-ux-infra_services
jennypavlova
commented
Nov 25, 2024
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
added
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
changed the title
x-pack/plugins/observability_solution/inventory/public/hooks/use_discover_redirect.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/hooks/use_discover_redirect.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/hooks/use_entity_definition.ts
Outdated
Show resolved
Hide resolved
…es-from-entity-definition' of https://github.com/jennypavlova/kibana into 200595-inventory-open-in-discover-link-should-use-indices-from-entity-definition
…d-use-indices-from-entity-definition
…d-use-indices-from-entity-definition
…d-use-indices-from-entity-definition
…d-use-indices-from-entity-definition
…d-use-indices-from-entity-definition
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
|
miltonhultgren
approved these changes
Nov 27, 2024
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit afc5e51)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit afc5e51)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2024
) (#202154) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Change discover link to use entity definition (#201433)](#201433) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T11:44:20Z","message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0"],"title":"[Inventory] Change discover link to use entity definition","number":201433,"url":"https://github.com/elastic/kibana/pull/201433","mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201433","number":201433,"mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2024
…1433) (#202153) # Backport This will backport the following commits from `main` to `8.17`: - [[Inventory] Change discover link to use entity definition (#201433)](#201433) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T11:44:20Z","message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0"],"title":"[Inventory] Change discover link to use entity definition","number":201433,"url":"https://github.com/elastic/kibana/pull/201433","mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201433","number":201433,"mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <[email protected]>
kibanamachine
removed
the
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200595
Summary
This PR changes the link to discover:
Testing
...in the actions columnExplore in DiscoverThe results should be filtered by the selected entity and the dataview should include the indices from the entity definition:
no_filter_discover_link.mov
k8s_discover_link.mov
With service type filter (should not persist)
service_filter_discover_link.mov