Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] [Inventory] Fix the link to discover test (#201197) #201326

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[8.17] [Inventory] Fix the link to discover test (#201197) #201326

merged 1 commit into from
Nov 22, 2024

Conversation

crespocarlos
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: jennypavlova "}}]}] BACKPORT-->

@jennypavlova
[Inventory] Fix the link to discover test (elastic#201197)
1637c23 
Closes elastic#201189

## Summary

After this fix was added in
elastic#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.

(cherry picked from commit 74cf5d4)
@crespocarlos crespocarlos enabled auto-merge (squash) November 22, 2024 09:20
@crespocarlos crespocarlos mentioned this pull request Nov 22, 2024
Merged
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

jennypavlova
jennypavlova reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@crespocarlos crespocarlos merged commit 3c2c4f2 into elastic:8.17 Nov 22, 2024
28 checks passed
@crespocarlos crespocarlos deleted the backport/8.17/pr-201197 branch November 22, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancof iblancof iblancof approved these changes

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crespocarlos @jennypavlova @miloszmarcinkowski @iblancof