Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logs Explorer deprecation messages #201307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davismcphee
Copy link
Contributor

Summary

It was pointed out in #199255 (comment) that the Logs Explorer deprecation messages may no longer be accurate now that contextual logs features are only available in Discover in the Observability solution view for 8.x:
image

I'm not really sure what they should updated to instead, so hopefully @elastic/obs-ux-logs-team can offer some suggestions.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team Project:OneDiscover Enrich Discover with contextual awareness backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Nov 22, 2024
@davismcphee davismcphee self-assigned this Nov 22, 2024
@davismcphee davismcphee requested review from a team as code owners November 22, 2024 02:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 22, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.8MB 1.8MB -494.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityLogsExplorer 15.3KB 15.2KB -101.0B

cc @davismcphee

@tonyghiani
Copy link
Contributor

@davismcphee You raised a good point here, after the latest changes on Discover, the classic navigation experience will not benefit from all the work done here. @LucaWintergerst This means that all those users still on the Classic navigation view will not have any Logs-centric browsing experience, which isn't ideal.

@flash1293
Copy link
Contributor

I think the plan is to enable the new navigation by default in 9.0, is that right? If yes, I think it would be OK to lean on that, but it's definitely a good point to consider, referring to Luca here.

@davismcphee
Copy link
Contributor Author

@tonyghiani @flash1293 Thanks both for taking a look. I noticed there were some discussions in Slack about this today, so please let me know if you come to a conclusion about this and I can update the PR accordingly. We can always discuss further among the One Discover group too and figure something out together if needed.

@LucaWintergerst
Copy link
Contributor

We'll need another round of discussions in general, not necessarily for this particular issue but more for the general approach we have planned
We'll chat next week and likely make a call soon

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyghiani
Copy link
Contributor

@davismcphee Given the offline sync we had the past week with the team, do you believe this change is still relevant?
Or shall we consider opening a new PR to introduce a more restrictive profile for the classic discover where some logs features are enabled?

@jughosta
Copy link
Contributor

jughosta commented Dec 3, 2024

Also, what about opening "Discover" tab by default in Observability project? It's odd that currently user presses "Discover" in the main nav and lands on "Logs Explorer" with a large "Deprecation notice". Can we rather focus "Discover" tab instead by default?

Dec-03-2024 11-30-36

@LucaWintergerst
Copy link
Contributor

I would be in favor of changing the default, but would need the input from the others if there are good reasons that this was not done already

@davismcphee
Copy link
Contributor Author

Given the offline sync we had the past week with the team, do you believe this change is still relevant?

@tonyghiani Probably not and we can definitely close it if we know we won't be changing these messages.

Or shall we consider opening a new PR to introduce a more restrictive profile for the classic discover where some logs features are enabled?

I'd certainly be ok with this approach, but I think it still needs to be agreed on at the product level first, so it's more a question for @LucaWintergerst and @ninoslavmiskovic.

Also, what about opening "Discover" tab by default in Observability project?

Yeah this a good point too. I agree with @LucaWintergerst that it would make sense to do this unless @elastic/obs-ux-logs-team has a good reason why they wouldn't want to.

@LucaWintergerst
Copy link
Contributor

we will discuss this 1 week from today in the DnD sync, until then we can't really make a decision

@ninoslavmiskovic
Copy link
Contributor

We are still striving to make the on-prem to include the new navigation. More update on one discover sync Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Project:OneDiscover Enrich Discover with contextual awareness release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team v8.17.0 v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants