-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Logs Explorer deprecation messages #201307
base: main
Are you sure you want to change the base?
Update Logs Explorer deprecation messages #201307
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @davismcphee |
@davismcphee You raised a good point here, after the latest changes on Discover, the classic navigation experience will not benefit from all the work done here. @LucaWintergerst This means that all those users still on the Classic navigation view will not have any Logs-centric browsing experience, which isn't ideal. |
I think the plan is to enable the new navigation by default in 9.0, is that right? If yes, I think it would be OK to lean on that, but it's definitely a good point to consider, referring to Luca here. |
@tonyghiani @flash1293 Thanks both for taking a look. I noticed there were some discussions in Slack about this today, so please let me know if you come to a conclusion about this and I can update the PR accordingly. We can always discuss further among the One Discover group too and figure something out together if needed. |
We'll need another round of discussions in general, not necessarily for this particular issue but more for the general approach we have planned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davismcphee Given the offline sync we had the past week with the team, do you believe this change is still relevant? |
I would be in favor of changing the default, but would need the input from the others if there are good reasons that this was not done already |
@tonyghiani Probably not and we can definitely close it if we know we won't be changing these messages.
I'd certainly be ok with this approach, but I think it still needs to be agreed on at the product level first, so it's more a question for @LucaWintergerst and @ninoslavmiskovic.
Yeah this a good point too. I agree with @LucaWintergerst that it would make sense to do this unless @elastic/obs-ux-logs-team has a good reason why they wouldn't want to. |
we will discuss this 1 week from today in the DnD sync, until then we can't really make a decision |
We are still striving to make the on-prem to include the new navigation. More update on one discover sync Thursday. |
Summary
It was pointed out in #199255 (comment) that the Logs Explorer deprecation messages may no longer be accurate now that contextual logs features are only available in Discover in the Observability solution view for 8.x:
I'm not really sure what they should updated to instead, so hopefully @elastic/obs-ux-logs-team can offer some suggestions.
Checklist
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelines