Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded preconfigured ELSER endpoint #201300

Conversation

Samiul-TheSoccerFan
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan commented Nov 21, 2024

Summary

The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana.

This needs to go after #elastic/elasticsearch#117294 merges in 8.17 and further.

Screen.Recording.2024-11-21.at.5.25.51.PM.mov

@Samiul-TheSoccerFan Samiul-TheSoccerFan marked this pull request as ready for review November 21, 2024 22:32
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested review from a team as code owners November 21, 2024 22:32
@Samiul-TheSoccerFan Samiul-TheSoccerFan added the backport:version Backport to applied version labels label Nov 21, 2024
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - can you add a test?

@Samiul-TheSoccerFan
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -98.0B
indexManagement 698.5KB 698.2KB -277.0B
total -375.0B

History

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good and work well

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit b3d638b into elastic:main Nov 26, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12032975195

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.17 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 201300

Questions ?

Please refer to the Backport tool documentation

@Samiul-TheSoccerFan
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Nov 26, 2024
## Summary

The Index mapping will have access to default elser inference endpoint
so we do not need to hardcode endpoint names in the Kibana.

This needs to go after
#elastic/elasticsearch#117294 merges in `8.17`
and further.

https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit b3d638b)

# Conflicts:
#	x-pack/plugins/translations/translations/zh-CN.json
@Samiul-TheSoccerFan
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Nov 26, 2024
## Summary

The Index mapping will have access to default elser inference endpoint
so we do not need to hardcode endpoint names in the Kibana.

This needs to go after
#elastic/elasticsearch#117294 merges in `8.17`
and further.

https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit b3d638b)

# Conflicts:
#	x-pack/plugins/translations/translations/zh-CN.json
Samiul-TheSoccerFan added a commit that referenced this pull request Nov 26, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove hardcoded preconfigured ELSER endpoint
(#201300)](#201300)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Samiul-TheSoccerFan added a commit that referenced this pull request Nov 26, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [Remove hardcoded preconfigured ELSER endpoint
(#201300)](#201300)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove
hardcoded preconfigured ELSER endpoint (#201300)\n\n##
Summary\r\n\r\nThe Index mapping will have access to default elser
inference endpoint\r\nso we do not need to hardcode endpoint names in
the Kibana.\r\n\r\nThis needs to go
after\r\n#elastic/elasticsearch#117294 merges in
`8.17`\r\nand
further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201811","number":201811,"state":"OPEN"}]}]
BACKPORT-->
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

The Index mapping will have access to default elser inference endpoint
so we do not need to hardcode endpoint names in the Kibana.

This needs to go after
#elastic/elasticsearch#117294 merges in `8.17`
and further.


https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd

---------

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

The Index mapping will have access to default elser inference endpoint
so we do not need to hardcode endpoint names in the Kibana.

This needs to go after
#elastic/elasticsearch#117294 merges in `8.17`
and further.


https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants