-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded preconfigured ELSER endpoint #201300
Remove hardcoded preconfigured ELSER endpoint #201300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - can you add a test?
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good and work well
Starting backport for target branches: 8.17, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b3d638b) # Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b3d638b) # Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
# Backport This will backport the following commits from `main` to `8.x`: - [Remove hardcoded preconfigured ELSER endpoint (#201300)](#201300) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
# Backport This will backport the following commits from `main` to `8.17`: - [Remove hardcoded preconfigured ELSER endpoint (#201300)](#201300) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T14:42:20Z","message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"number":201300,"url":"https://github.com/elastic/kibana/pull/201300","mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201300","number":201300,"mergeCommit":{"message":"Remove hardcoded preconfigured ELSER endpoint (#201300)\n\n## Summary\r\n\r\nThe Index mapping will have access to default elser inference endpoint\r\nso we do not need to hardcode endpoint names in the Kibana.\r\n\r\nThis needs to go after\r\n#elastic/elasticsearch#117294 merges in `8.17`\r\nand further.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"b3d638b7cf3022fbe1e0fb019462ad9df6d52f25"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201811","number":201811,"state":"OPEN"}]}] BACKPORT-->
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]>
## Summary The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana. This needs to go after #elastic/elasticsearch#117294 merges in `8.17` and further. https://github.com/user-attachments/assets/4a786fde-e250-440d-a9d7-2256dacc8edd --------- Co-authored-by: Elastic Machine <[email protected]>
Summary
The Index mapping will have access to default elser inference endpoint so we do not need to hardcode endpoint names in the Kibana.
This needs to go after #elastic/elasticsearch#117294 merges in
8.17
and further.Screen.Recording.2024-11-21.at.5.25.51.PM.mov