Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding telemetry for the fips config #201282

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

kc13greiner
Copy link
Contributor

@kc13greiner kc13greiner commented Nov 21, 2024

Summary

Adding telemetry for the fipsMode.enabled config

@kc13greiner kc13greiner added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Nov 21, 2024
@kc13greiner kc13greiner self-assigned this Nov 21, 2024
@kc13greiner kc13greiner linked an issue Nov 21, 2024 that may be closed by this pull request
@kc13greiner kc13greiner marked this pull request as ready for review November 26, 2024 13:14
@kc13greiner kc13greiner requested review from a team as code owners November 26, 2024 13:14
@SiddharthMantri SiddharthMantri self-requested a review November 26, 2024 14:01
Copy link
Contributor

@SiddharthMantri SiddharthMantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kc13greiner
Copy link
Contributor Author

/ci

@kc13greiner
Copy link
Contributor Author

/ci

@kc13greiner
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @kc13greiner

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changed LGTM.

Just FYI, there's already an automatic collection for configuration user overrides. That being said, I can see that the collector is used for this purpose and switching to the other source might imply breaking changes downstream, so approving this approach as well.

@kc13greiner kc13greiner merged commit 8f12d52 into elastic:main Dec 2, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12119719924

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
## Summary

Adding telemetry for the `fipsMode.enabled` config

(cherry picked from commit 8f12d52)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
## Summary

Adding telemetry for the `fipsMode.enabled` config

(cherry picked from commit 8f12d52)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Adding telemetry for the fips config
(#201282)](#201282)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Kurt","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T12:50:40Z","message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"Adding
telemetry for the fips
config","number":201282,"url":"https://github.com/elastic/kibana/pull/201282","mergeCommit":{"message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201282","number":201282,"mergeCommit":{"message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kurt <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [Adding telemetry for the fips config
(#201282)](#201282)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Kurt","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T12:50:40Z","message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"Adding
telemetry for the fips
config","number":201282,"url":"https://github.com/elastic/kibana/pull/201282","mergeCommit":{"message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201282","number":201282,"mergeCommit":{"message":"Adding
telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding
telemetry for the `fipsMode.enabled`
config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kurt <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Adding telemetry for the `fipsMode.enabled` config
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Adding telemetry for the `fipsMode.enabled` config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIPS] Add usage telemetry for the FIPS config
5 participants