-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding telemetry for the fips config #201282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/ci |
/ci |
/ci |
💚 Build Succeeded
Metrics [docs]
History
cc @kc13greiner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telemetry changed LGTM.
Just FYI, there's already an automatic collection for configuration user overrides. That being said, I can see that the collector is used for this purpose and switching to the other source might imply breaking changes downstream, so approving this approach as well.
Starting backport for target branches: 8.17, 8.x |
## Summary Adding telemetry for the `fipsMode.enabled` config (cherry picked from commit 8f12d52)
## Summary Adding telemetry for the `fipsMode.enabled` config (cherry picked from commit 8f12d52)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [Adding telemetry for the fips config (#201282)](#201282) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kurt","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T12:50:40Z","message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"Adding telemetry for the fips config","number":201282,"url":"https://github.com/elastic/kibana/pull/201282","mergeCommit":{"message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201282","number":201282,"mergeCommit":{"message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kurt <[email protected]>
# Backport This will backport the following commits from `main` to `8.17`: - [Adding telemetry for the fips config (#201282)](#201282) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kurt","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T12:50:40Z","message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"Adding telemetry for the fips config","number":201282,"url":"https://github.com/elastic/kibana/pull/201282","mergeCommit":{"message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201282","number":201282,"mergeCommit":{"message":"Adding telemetry for the fips config (#201282)\n\n## Summary\r\n\r\nAdding telemetry for the `fipsMode.enabled` config","sha":"8f12d521385f6b61f1782685acaca89c9910809d"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kurt <[email protected]>
## Summary Adding telemetry for the `fipsMode.enabled` config
## Summary Adding telemetry for the `fipsMode.enabled` config
Summary
Adding telemetry for the
fipsMode.enabled
config