[8.x] [Inventory] Fix the link to discover test (#201197) #201252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#201189 ## Summary After this fix was added in elastic#200984 the test started failing as it was verifying the previous kuery value - it was missing the `" "` so after this bug was fixed the test should be updated as well (basically changing `container.id:foo` with `container.id:"foo"`) and this PR updates the test. I checked locally and the test is passing now. (cherry picked from commit 74cf5d4)
botelastic
bot
added
the
ci:project-deploy-observability
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
|
crespocarlos
added a commit
that referenced
this pull request
Nov 22, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[Inventory] Fix the link to discover test (#201197)](#201197) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T17:14:43Z","message":"[Inventory] Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n## Summary\r\n\r\nAfter this fix was added in\r\nhttps://github.com//pull/200984 the test started failing\r\nas it was verifying the previous kuery value - it was missing the `\" \"`\r\nso after this bug was fixed the test should be updated as well\r\n(basically changing `container.id:foo` with `container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI checked locally and the test is passing now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":201197,"url":"https://github.com/elastic/kibana/pull/201197","mergeCommit":{"message":"[Inventory] Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n## Summary\r\n\r\nAfter this fix was added in\r\nhttps://github.com//pull/200984 the test started failing\r\nas it was verifying the previous kuery value - it was missing the `\" \"`\r\nso after this bug was fixed the test should be updated as well\r\n(basically changing `container.id:foo` with `container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI checked locally and the test is passing now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201197","number":201197,"mergeCommit":{"message":"[Inventory] Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n## Summary\r\n\r\nAfter this fix was added in\r\nhttps://github.com//pull/200984 the test started failing\r\nas it was verifying the previous kuery value - it was missing the `\" \"`\r\nso after this bug was fixed the test should be updated as well\r\n(basically changing `container.id:foo` with `container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI checked locally and the test is passing now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201252","number":201252,"state":"MERGED","mergeCommit":{"sha":"b342de58951e78ad8921704499231a9d78100ca9","message":"[8.x] [Inventory] Fix the link to discover test (#201197) (#201252)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Inventory] Fix the link to discover test\n(#201197)](https://github.com/elastic/kibana/pull/201197)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"jennypavlova\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-21T17:14:43Z\",\"message\":\"[Inventory]\nFix the link to discover test (#201197)\\n\\nCloses #201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was added\nin\\r\\nhttps://github.com//pull/200984 the test started\nfailing\\r\\nas it was verifying the previous kuery value - it was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test should be updated as\nwell\\r\\n(basically changing `container.id:foo` with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the test.\\r\\n\\r\\nI\nchecked locally and the test is passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\"],\"title\":\"[Inventory]\nFix the link to discover\ntest\",\"number\":201197,\"url\":\"https://github.com/elastic/kibana/pull/201197\",\"mergeCommit\":{\"message\":\"[Inventory]\nFix the link to discover test (#201197)\\n\\nCloses #201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was added\nin\\r\\nhttps://github.com//pull/200984 the test started\nfailing\\r\\nas it was verifying the previous kuery value - it was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test should be updated as\nwell\\r\\n(basically changing `container.id:foo` with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the test.\\r\\n\\r\\nI\nchecked locally and the test is passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201197\",\"number\":201197,\"mergeCommit\":{\"message\":\"[Inventory]\nFix the link to discover test (#201197)\\n\\nCloses #201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was added\nin\\r\\nhttps://github.com//pull/200984 the test started\nfailing\\r\\nas it was verifying the previous kuery value - it was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test should be updated as\nwell\\r\\n(basically changing `container.id:foo` with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the test.\\r\\n\\r\\nI\nchecked locally and the test is passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\"}}]}] BACKPORT-->\n\nCo-authored-by: jennypavlova <[email protected]>"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation