[Fleet] Handle unavailable spaces in agent policy space selector #201251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillguyonnet
added
Team:Fleet
|
This looks a good solution to me, we should probably remove the |
Good catch, thanks! I pushed a fix. I kept it local to the component instead of centralising the One general concern I had is that this fix relies on the Saved Objects API returning |
|
Pinging @elastic/fleet (Team:Fleet) |
jillguyonnet
added
the
backport:prev-minor
It seems pretty reliable, the space plugin seems to use that behavior frequently in their code, it seems also they expose a |
Cheers 👍 I pushed a commit to use the constant. |
|
Is there anything preventing us from hiding the spaces entirely instead of displaying "unavailable space"? This badge isn't actionable for users with limited space access, and seems like it's adding UI noise for them. |
Nothing preventing, it's a small change. My thinking was that this shows more clearly why the input is disabled, but with the tooltip it shouldn't be a concern. If showing how many unavailable spaces are assigned is a concern, then I'm definitely happy to hide them instead. |
If we're relying on spaces as an information/data isolation mechanism, I think a user with permissions to only 2 spaces should not know there are 12 available spaces in Kibana. Hiding the spaces entirely seems like the more "proper" thing to do when it comes to data isolation. I'd be in favor of making this change here. |
Thank you, agreed and done. I've updated the PR description. |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
jillguyonnet
deleted the
fleet/193827-fix-agent-policy-space-selector
branch
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
…stic#201251) ## Summary Closes elastic#193827 This PR improves the space selector in agent policy setting to handle the case where the user does not have access to all policy spaces. In this case: * Space selection is disabled * The "Create space" link is hidden * A tooltip is shown to inform the user why the input is disabled * The inaccessible space badges are given an `Unavailable space` badge ### Screenshots For a user with access to all policy spaces (no change):  For a user with access to only a subset of policy spaces:  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit db49418)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
#201251) (#201580) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Handle unavailable spaces in agent policy space selector (#201251)](#201251) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jill Guyonnet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T12:49:23Z","message":"[Fleet] Handle unavailable spaces in agent policy space selector (#201251)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193827\r\n\r\nThis PR improves the space selector in agent policy setting to handle\r\nthe case where the user does not have access to all policy spaces.\r\n\r\nIn this case:\r\n* Space selection is disabled\r\n* The \"Create space\" link is hidden\r\n* A tooltip is shown to inform the user why the input is disabled\r\n* The inaccessible space badges are given an `Unavailable space` badge\r\n\r\n### Screenshots\r\n\r\nFor a user with access to all policy spaces (no change):\r\n\r\n\r\nFor a user with access to only a subset of policy spaces:\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"db494181e37a3f3477361fc1c1919fc7ed3a1329","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Handle unavailable spaces in agent policy space selector","number":201251,"url":"https://github.com/elastic/kibana/pull/201251","mergeCommit":{"message":"[Fleet] Handle unavailable spaces in agent policy space selector (#201251)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193827\r\n\r\nThis PR improves the space selector in agent policy setting to handle\r\nthe case where the user does not have access to all policy spaces.\r\n\r\nIn this case:\r\n* Space selection is disabled\r\n* The \"Create space\" link is hidden\r\n* A tooltip is shown to inform the user why the input is disabled\r\n* The inaccessible space badges are given an `Unavailable space` badge\r\n\r\n### Screenshots\r\n\r\nFor a user with access to all policy spaces (no change):\r\n\r\n\r\nFor a user with access to only a subset of policy spaces:\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"db494181e37a3f3477361fc1c1919fc7ed3a1329"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201251","number":201251,"mergeCommit":{"message":"[Fleet] Handle unavailable spaces in agent policy space selector (#201251)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193827\r\n\r\nThis PR improves the space selector in agent policy setting to handle\r\nthe case where the user does not have access to all policy spaces.\r\n\r\nIn this case:\r\n* Space selection is disabled\r\n* The \"Create space\" link is hidden\r\n* A tooltip is shown to inform the user why the input is disabled\r\n* The inaccessible space badges are given an `Unavailable space` badge\r\n\r\n### Screenshots\r\n\r\nFor a user with access to all policy spaces (no change):\r\n\r\n\r\nFor a user with access to only a subset of policy spaces:\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"db494181e37a3f3477361fc1c1919fc7ed3a1329"}}]}] BACKPORT--> Co-authored-by: Jill Guyonnet <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…stic#201251) ## Summary Closes elastic#193827 This PR improves the space selector in agent policy setting to handle the case where the user does not have access to all policy spaces. In this case: * Space selection is disabled * The "Create space" link is hidden * A tooltip is shown to inform the user why the input is disabled * The inaccessible space badges are given an `Unavailable space` badge ### Screenshots For a user with access to all policy spaces (no change):  For a user with access to only a subset of policy spaces:  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…stic#201251) ## Summary Closes elastic#193827 This PR improves the space selector in agent policy setting to handle the case where the user does not have access to all policy spaces. In this case: * Space selection is disabled * The "Create space" link is hidden * A tooltip is shown to inform the user why the input is disabled * The inaccessible space badges are given an `Unavailable space` badge ### Screenshots For a user with access to all policy spaces (no change):  For a user with access to only a subset of policy spaces:  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #193827
This PR improves the space selector in agent policy setting to handle the case where the user does not have access to all policy spaces.
In this case:
Unavailable spacebadgeScreenshots
For a user with access to all policy spaces (no change):
For a user with access to only a subset of policy spaces:
Checklist
release_note:*label is applied per the guidelines