Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip failing serverless tests in release branch #201248

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Skip failing serverless tests in release branch #201248

merged 2 commits into from
Nov 21, 2024

Conversation

paul-tavares
Copy link
Contributor

Summary

  • Skips serverless cypress tests in release branch, since they are failing

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Nov 21, 2024
@paul-tavares paul-tavares self-assigned this Nov 21, 2024
@paul-tavares paul-tavares requested a review from a team as a code owner November 21, 2024 17:04
@paul-tavares paul-tavares requested review from ashokaditya and gergoabraham and removed request for a team November 21, 2024 17:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares enabled auto-merge (squash) November 21, 2024 17:33
parkiino
parkiino approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@parkiino parkiino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im guessing the @skipInServerless is what allows you to skip the tests right?

@paul-tavares
Copy link
Contributor Author

im guessing the @skipInServerless is what allows you to skip the tests right?

@parkiino yes... there are a few tags that seem to be used for skipping, so I just added them all :)

thanks for the 👍

@paul-tavares paul-tavares merged commit 5c06edc into elastic:8.16 Nov 21, 2024
34 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @paul-tavares

@paul-tavares paul-tavares deleted the task/v816-skip-cypress-serverless-tests branch November 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkiino parkiino parkiino approved these changes

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-defend-workflows

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham was automatically assigned from elastic/security-defend-workflows

Assignees

@paul-tavares paul-tavares

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-tavares @elasticmachine @parkiino