fix(slo): Add missing new context providers around burn rate editor #201199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
commented
Nov 21, 2024
Comment on lines
+70
to
+72
| ruleParamsExpression: lazyWithContextProviders( | ||
| lazy(() => import('../components/burn_rate_rule_editor')) | ||
| ), |
There was a problem hiding this comment.
💬 Same as alertDetailsAppSection below
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
fkanout
approved these changes
Nov 21, 2024
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…lastic#201199) (cherry picked from commit 324ecc2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…lastic#201199) (cherry picked from commit 324ecc2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…itor (#201199) (#201233) # Backport This will backport the following commits from `main` to `8.x`: - [fix(slo): Add missing new context providers around burn rate editor (#201199)](#201199) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:12:10Z","message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): Add missing new context providers around burn rate editor","number":201199,"url":"https://github.com/elastic/kibana/pull/201199","mergeCommit":{"message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201199","number":201199,"mergeCommit":{"message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…ditor (#201199) (#201232) # Backport This will backport the following commits from `main` to `8.17`: - [fix(slo): Add missing new context providers around burn rate editor (#201199)](#201199) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:12:10Z","message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): Add missing new context providers around burn rate editor","number":201199,"url":"https://github.com/elastic/kibana/pull/201199","mergeCommit":{"message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201199","number":201199,"mergeCommit":{"message":"fix(slo): Add missing new context providers around burn rate editor (#201199)","sha":"324ecc2c37e59f55643bd5685bb1db08be4a4fb9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #198683
🍒 Summary
This PR addresses an issue with the burn rate editor registration. We forgot to wrap this component with the new context providers introduced while migrating to the new router.
This was making the editor fails when opened from outside the SLO page.
🧬 Testing
Make sure you can create/edit an SLO burn rate rule from the
Observability > Rulespage