Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Serverless]Maintenance window page displays dead breadcrumb for management #201147

Merged
merged 20 commits into from
Dec 10, 2024
Merged

[ResponseOps][Serverless]Maintenance window page displays dead breadcrumb for management #201147

merged 20 commits into from
Dec 10, 2024

Conversation

georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Nov 21, 2024 •
edited by kibanamachine
Loading

Closes #189318

Summary

  • the issue was resolved by using useKibana.services.serverless.setBreadcrumbs instead of chrome.setBreadcrumbs, this ensures that breadcrumb functionality is correctly handled within serverless observability.
Screen.Recording.2024-11-21.at.14.20.39.mov

@georgianaonoleata1904 georgianaonoleata1904 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Nov 21, 2024
@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Nov 21, 2024
@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner November 21, 2024 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner November 27, 2024 12:44
adcoelho
adcoelho reviewed Nov 27, 2024
View reviewed changes
x-pack/plugins/alerting/public/plugin.ts
@@ -68,6 +69,7 @@ export interface AlertingPluginStart {
spaces: SpacesPluginStart;
unifiedSearch: UnifiedSearchPublicPluginStart;
data: DataPublicPluginStart;
serverless?: ServerlessPluginStart;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is changing this type enough? How does this guarantee that useKibana has it whenever the hook is called?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it correctly reflects (with the ?) the fact that the serverless plugin is not required but optional in alerting's kibana.jsonc config file

@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner November 27, 2024 14:13
cauemarcondes
cauemarcondes approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBS changes LGTM

cnasikas
cnasikas approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both ESS and Serverless and is working as expected.

Dosant
Dosant approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/test_serverless/functional/test_suites/security/ftr/navigation.ts logs good, just seems @cnasikas's suggestion wasn't added https://github.com/elastic/kibana/pull/201147/files?file-filters%5B%5D=.jsonc&file-filters%5B%5D=.ts&owned-by%5B%5D=Dosant&show-viewed-files=true#r1875878554

@georgianaonoleata1904
Copy link
Contributor Author

x-pack/test_serverless/functional/test_suites/security/ftr/navigation.ts logs good, just seems @cnasikas's suggestion wasn't added https://github.com/elastic/kibana/pull/201147/files?file-filters%5B%5D=.jsonc&file-filters%5B%5D=.ts&owned-by%5B%5D=Dosant&show-viewed-files=true#r1875878554

Added it! Thanks :)

@cnasikas cnasikas added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development v8.18.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Dec 10, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 100.2KB 100.3KB +68.0B

History

cc @georgianaonoleata1904

@georgianaonoleata1904 georgianaonoleata1904 merged commit 5a67a03 into elastic:main Dec 10, 2024
14 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12260202276

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@georgianaonoleata1904
[ResponseOps][Serverless]Maintenance window page displays dead breadc…
a31b06b 
…rumb for management (elastic#201147)

Closes elastic#189318

## Summary

- the issue was resolved by using
useKibana.services.serverless.setBreadcrumbs instead of
chrome.setBreadcrumbs, this ensures that breadcrumb functionality is
correctly handled within serverless observability.

https://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb
(cherry picked from commit 5a67a03)
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@georgianaonoleata1904
[ResponseOps][Serverless]Maintenance window page displays dead breadc…
7ec7bf1 
…rumb for management (elastic#201147)

Closes elastic#189318

## Summary

- the issue was resolved by using
useKibana.services.serverless.setBreadcrumbs instead of
chrome.setBreadcrumbs, this ensures that breadcrumb functionality is
correctly handled within serverless observability.

https://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb
(cherry picked from commit 5a67a03)
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts
❌ 8.16 Backport failed because of merge conflicts
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 201147

Questions ?

Please refer to the Backport tool documentation

@cnasikas cnasikas added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 10, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12260448615

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@georgianaonoleata1904
[ResponseOps][Serverless]Maintenance window page displays dead breadc…
55570ee 
…rumb for management (elastic#201147)

Closes elastic#189318

## Summary

- the issue was resolved by using
useKibana.services.serverless.setBreadcrumbs instead of
chrome.setBreadcrumbs, this ensures that breadcrumb functionality is
correctly handled within serverless observability.

https://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb
(cherry picked from commit 5a67a03)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
@kibanamachine @georgianaonoleata1904
[8.x] [ResponseOps][Serverless]Maintenance window page displays dead …
d01037c 
…breadcrumb for management (#201147) (#203636)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Serverless]Maintenance window page displays dead
breadcrumb for management
(#201147)](#201147)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgiana-Andreea
Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T16:13:43Z","message":"[ResponseOps][Serverless]Maintenance
window page displays dead breadcrumb for management (#201147)\n\nCloses
https://github.com/elastic/kibana/issues/189318\r\n\r\n##
Summary\r\n\r\n- the issue was resolved by
using\r\nuseKibana.services.serverless.setBreadcrumbs instead
of\r\nchrome.setBreadcrumbs, this ensures that breadcrumb functionality
is\r\ncorrectly handled within serverless
observability.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb","sha":"5a67a033a3f29ea72028dc4e2f2b3c43b6d36551","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-major","v8.18.0"],"title":"[ResponseOps][Serverless]Maintenance
window page displays dead breadcrumb for
management","number":201147,"url":"https://github.com/elastic/kibana/pull/201147","mergeCommit":{"message":"[ResponseOps][Serverless]Maintenance
window page displays dead breadcrumb for management (#201147)\n\nCloses
https://github.com/elastic/kibana/issues/189318\r\n\r\n##
Summary\r\n\r\n- the issue was resolved by
using\r\nuseKibana.services.serverless.setBreadcrumbs instead
of\r\nchrome.setBreadcrumbs, this ensures that breadcrumb functionality
is\r\ncorrectly handled within serverless
observability.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb","sha":"5a67a033a3f29ea72028dc4e2f2b3c43b6d36551"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201147","number":201147,"mergeCommit":{"message":"[ResponseOps][Serverless]Maintenance
window page displays dead breadcrumb for management (#201147)\n\nCloses
https://github.com/elastic/kibana/issues/189318\r\n\r\n##
Summary\r\n\r\n- the issue was resolved by
using\r\nuseKibana.services.serverless.setBreadcrumbs instead
of\r\nchrome.setBreadcrumbs, this ensures that breadcrumb functionality
is\r\ncorrectly handled within serverless
observability.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb","sha":"5a67a033a3f29ea72028dc4e2f2b3c43b6d36551"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@georgianaonoleata1904 @CAWilson94
[ResponseOps][Serverless]Maintenance window page displays dead breadc…
f52c06f 
…rumb for management (elastic#201147)

Closes elastic#189318

## Summary

- the issue was resolved by using
useKibana.services.serverless.setBreadcrumbs instead of
chrome.setBreadcrumbs, this ensures that breadcrumb functionality is
correctly handled within serverless observability.



https://github.com/user-attachments/assets/d805b54f-74b4-424f-8304-dced09718ebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbopepato umbopepato umbopepato left review comments

@cnasikas cnasikas cnasikas approved these changes

@adcoelho adcoelho adcoelho left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@jcger jcger jcger approved these changes

@Dosant Dosant Dosant approved these changes

@rudolf rudolf rudolf approved these changes

Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serverless-QA] Maintenance window page displays dead breadcrumb for management
10 participants
@georgianaonoleata1904 @elasticmachine @kibanamachine @rudolf @adcoelho @Dosant @cnasikas @jcger @umbopepato @cauemarcondes