-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] [Playground] [Bug] Add playground index validation #201032
Merged
yansavitski
merged 14 commits into
elastic:main
from
yansavitski:add-playground-index-validation
Nov 25, 2024
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b66a80d
Add useIndicesValidation hook
yansavitski 9f119f5
Add ftr test
yansavitski b752251
Fix types
yansavitski f86dc37
Fix filter type
yansavitski 77a1e84
Fix types in test
yansavitski 9d19ee5
Merge branch 'main' of github.com:elastic/kibana into add-playground-…
yansavitski 7373c78
Add target indices to getIndices request
yansavitski 1bf281f
Add validation by exact field
yansavitski b5a8238
Fix types
yansavitski 4c68106
Return 50 indices to prevent unselect index bug
yansavitski 465d075
Fix tests
yansavitski b9c336b
Merge branch 'main' of github.com:elastic/kibana into add-playground-…
yansavitski 9f61325
Fix validation test
yansavitski f132064
Merge branch 'main' into add-playground-index-validation
yansavitski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
x-pack/plugins/search_playground/public/hooks/use_indices_validation.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { useEffect, useState } from 'react'; | ||
import { useQueryIndices } from './use_query_indices'; | ||
|
||
export const useIndicesValidation = (unvalidatedIndices: string[]) => { | ||
const [isValidated, setIsValidated] = useState<boolean>(false); | ||
const [validIndices, setValidIndices] = useState<string[]>([]); | ||
const { indices, isFetched: isIndicesLoaded } = useQueryIndices({ | ||
targetIndices: unvalidatedIndices, | ||
}); | ||
|
||
useEffect(() => { | ||
if (isIndicesLoaded) { | ||
setValidIndices(indices.filter((index) => unvalidatedIndices.includes(index))); | ||
setIsValidated(true); | ||
} | ||
}, [unvalidatedIndices, indices, isIndicesLoaded]); | ||
|
||
return { isValidated, validIndices }; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useQueryIndices gets the top 10 indices, what happens if its not in this list but does exist?
I would do an explicit API call for all the unvalidatedIndices to see if they exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.elastic.co/guide/en/elasticsearch/reference/current/cat-indices.html supports a target.