[Session management] update cleanup to allow partial search results for PIT query #200912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults for PIT query
SiddharthMantri
added
bug
|
Pinging @elastic/kibana-security (Team:Security) |
SiddharthMantri
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
elena-shostak
approved these changes
Nov 21, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8f12714)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8f12714)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8f12714)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8f12714)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…sults for PIT query (#200912) (#201200) # Backport This will backport the following commits from `main` to `8.15`: - [[Session management] update cleanup to allow partial search results for PIT query (#200912)](#200912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:14:54Z","message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","v9.0.0","Feature:Security/Session Management","backport:prev-major"],"title":"[Session management] update cleanup to allow partial search results for PIT query","number":200912,"url":"https://github.com/elastic/kibana/pull/200912","mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200912","number":200912,"mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…ults for PIT query (#200912) (#201205) # Backport This will backport the following commits from `main` to `8.x`: - [[Session management] update cleanup to allow partial search results for PIT query (#200912)](#200912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:14:54Z","message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","v9.0.0","Feature:Security/Session Management","backport:prev-major"],"title":"[Session management] update cleanup to allow partial search results for PIT query","number":200912,"url":"https://github.com/elastic/kibana/pull/200912","mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200912","number":200912,"mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…sults for PIT query (#200912) (#201201) # Backport This will backport the following commits from `main` to `8.16`: - [[Session management] update cleanup to allow partial search results for PIT query (#200912)](#200912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:14:54Z","message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","v9.0.0","Feature:Security/Session Management","backport:prev-major"],"title":"[Session management] update cleanup to allow partial search results for PIT query","number":200912,"url":"https://github.com/elastic/kibana/pull/200912","mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200912","number":200912,"mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]>
|
This PR didn't make it into the latest BC of v8.16.1. Updating the labels. |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…sults for PIT query (#200912) (#201203) # Backport This will backport the following commits from `main` to `8.17`: - [[Session management] update cleanup to allow partial search results for PIT query (#200912)](#200912) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:14:54Z","message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","v9.0.0","Feature:Security/Session Management","backport:prev-major"],"title":"[Session management] update cleanup to allow partial search results for PIT query","number":200912,"url":"https://github.com/elastic/kibana/pull/200912","mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200912","number":200912,"mergeCommit":{"message":"[Session management] update cleanup to allow partial search results for PIT query (#200912)\n\nCloses https://github.com/elastic/kibana/issues/200008\r\n\r\n## Summary\r\nThis PR updates the session cleanup task to allow partial results in the\r\npoint in time query used to delete any invalid sessions.\r\n\r\n\r\n### Notes\r\nUsing a [recently introduced option by\r\nES](elastic/elasticsearch#111516), the session\r\ncleanup now allows the PIT to run over partial results. This should\r\nreduce the noise we see around session_cleanup errors in our logs.\r\n\r\n\r\n### Release notes\r\nFixes error with opening point in time query for session deletion by now\r\naccounting for partial results.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8f12714219ca4b4c8e58678d42e9978c3defa40b"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…or PIT query (elastic#200912) Closes elastic#200008 ## Summary This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions. ### Notes Using a [recently introduced option by ES](elastic/elasticsearch#111516), the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs. ### Release notes Fixes error with opening point in time query for session deletion by now accounting for partial results. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200008
Summary
This PR updates the session cleanup task to allow partial results in the point in time query used to delete any invalid sessions.
Notes
Using a recently introduced option by ES, the session cleanup now allows the PIT to run over partial results. This should reduce the noise we see around session_cleanup errors in our logs.
Release notes
Fixes error with opening point in time query for session deletion by now accounting for partial results.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_node:*label is applied per the guidelines