Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove unused nyc configs and dependencies #200909

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Nov 20, 2024

Summary

nyc (istanbuljs) cleanup as we no longer collect code coverage for functional tests

@dmlemeshko dmlemeshko added chore release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 labels Nov 20, 2024
@dmlemeshko dmlemeshko marked this pull request as ready for review November 20, 2024 13:10
@dmlemeshko dmlemeshko requested a review from a team as a code owner November 20, 2024 13:10
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / TableSearch renders with initial value correctly

Metrics [docs]

✅ unchanged

@dmlemeshko dmlemeshko merged commit 88a280c into elastic:main Nov 20, 2024
40 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11936753045

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 200909

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Nov 20, 2024
## Summary

nyc (istanbuljs) cleanup as we no longer collect code coverage for
functional tests

(cherry picked from commit 88a280c)

# Conflicts:
#	renovate.json
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request Nov 20, 2024
…200983)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[chore] remove unused nyc configs and dependencies
(#200909)](#200909)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T15:41:30Z","message":"[chore]
remove unused nyc configs and dependencies (#200909)\n\n##
Summary\r\n\r\nnyc (istanbuljs) cleanup as we no longer collect code
coverage for\r\nfunctional
tests","sha":"88a280c2505759d4fb0c64a00845ea17633d2f03","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","v9.0.0","backport:version","v8.17.0"],"number":200909,"url":"https://github.com/elastic/kibana/pull/200909","mergeCommit":{"message":"[chore]
remove unused nyc configs and dependencies (#200909)\n\n##
Summary\r\n\r\nnyc (istanbuljs) cleanup as we no longer collect code
coverage for\r\nfunctional
tests","sha":"88a280c2505759d4fb0c64a00845ea17633d2f03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200909","number":200909,"mergeCommit":{"message":"[chore]
remove unused nyc configs and dependencies (#200909)\n\n##
Summary\r\n\r\nnyc (istanbuljs) cleanup as we no longer collect code
coverage for\r\nfunctional
tests","sha":"88a280c2505759d4fb0c64a00845ea17633d2f03"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
## Summary

nyc (istanbuljs) cleanup as we no longer collect code coverage for
functional tests
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

nyc (istanbuljs) cleanup as we no longer collect code coverage for
functional tests
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

nyc (istanbuljs) cleanup as we no longer collect code coverage for
functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels chore release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants