Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover another fix attempt #200907

Closed
wants to merge 2 commits into from

Conversation

kertal
Copy link
Member

@kertal kertal commented Nov 20, 2024

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_node:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@kertal kertal self-assigned this Nov 20, 2024
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@kertal
Copy link
Member Author

kertal commented Nov 20, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7437

[❌] test/functional/apps/discover/group3/config.ts: 0/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 20, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / discover/group3 discover lens vis should close lens flyout on revert changes
  • [job] [logs] FTR Configs #44 / discover/group3 discover lens vis should close lens flyout on revert changes
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes with breakdown field
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes with breakdown field
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes with unsupported breakdown field
  • [job] [logs] Jest Tests #11 / LensVisService attributes should return correct attributes with unsupported breakdown field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedHistogram 71.3KB 71.3KB +20.0B

History

cc @kertal

@jughosta
Copy link
Contributor

Same error:

Screenshot 2024-11-20 at 16 26 37

@kertal
Copy link
Member Author

kertal commented Nov 20, 2024

Ok, thx, and another error, let's got with the other one

@kertal kertal closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants