Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UA] Fix reindex docs in README.md #200893

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[UA] Fix reindex docs in README.md #200893

merged 5 commits into from
Nov 20, 2024

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 20, 2024 •
edited by kibanamachine
Loading

Summary

Updates overview of Upgrade Assistant's reindexing actions. Also updates some doc comments.

Close #121237

@jloleysens jloleysens added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v9.0.0 backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Nov 20, 2024
@jloleysens jloleysens requested a review from a team November 20, 2024 11:02
@jloleysens jloleysens requested a review from a team as a code owner November 20, 2024 11:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens changed the title update docs and doc comments [UA] Fix reindex docs in README.md Nov 20, 2024
sabarasaba
sabarasaba approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs, changes lgtm 🚀

rudolf
rudolf approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion for a bit more detail on the switchAlias part but otherwise looks good

x-pack/plugins/upgrade_assistant/README.md Outdated Show resolved Hide resolved
@jloleysens jloleysens enabled auto-merge (squash) November 20, 2024 12:04
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@jloleysens jloleysens merged commit 3a6224f into elastic:main Nov 20, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11934721604

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@jloleysens
[UA] Fix reindex docs in README.md (elastic#200893)
6b6f0cb 
## Summary

Updates overview of Upgrade Assistant's reindexing actions. Also updates
some doc comments.

Close elastic#121237

<img width="1163" alt="Screenshot 2024-11-20 at 12 07 25"
src="https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648">

---------

Co-authored-by: Rudolf Meijering <[email protected]>
(cherry picked from commit 3a6224f)
@kibanamachine kibanamachine mentioned this pull request Nov 20, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.18 The branch "8.18" does not exist
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 200893

Questions ?

Please refer to the Backport tool documentation

@jloleysens jloleysens deleted the upgrade-assistant/update-reindexing-docs branch November 20, 2024 14:13
kibanamachine added a commit that referenced this pull request Nov 20, 2024
@kibanamachine @jloleysens
[8.x] [UA] Fix reindex docs in README.md (#200893) (#200925)
fd4ea58 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[UA] Fix reindex docs in README.md
(#200893)](#200893)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T13:48:22Z","message":"[UA]
Fix reindex docs in README.md (#200893)\n\n## Summary\r\n\r\nUpdates
overview of Upgrade Assistant's reindexing actions. Also updates\r\nsome
doc comments.\r\n\r\nClose
https://github.com/elastic/kibana/issues/121237\r\n\r\n<img
width=\"1163\" alt=\"Screenshot 2024-11-20 at 12 07
25\"\r\nsrc=\"https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Rudolf Meijering
<[email protected]>","sha":"3a6224f8594fa21a5f37a94542523fa6b77f2149","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Kibana
Management","release_note:skip","Feature:Upgrade
Assistant","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[UA]
Fix reindex docs in
README.md","number":200893,"url":"https://github.com/elastic/kibana/pull/200893","mergeCommit":{"message":"[UA]
Fix reindex docs in README.md (#200893)\n\n## Summary\r\n\r\nUpdates
overview of Upgrade Assistant's reindexing actions. Also updates\r\nsome
doc comments.\r\n\r\nClose
https://github.com/elastic/kibana/issues/121237\r\n\r\n<img
width=\"1163\" alt=\"Screenshot 2024-11-20 at 12 07
25\"\r\nsrc=\"https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Rudolf Meijering
<[email protected]>","sha":"3a6224f8594fa21a5f37a94542523fa6b77f2149"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200893","number":200893,"mergeCommit":{"message":"[UA]
Fix reindex docs in README.md (#200893)\n\n## Summary\r\n\r\nUpdates
overview of Upgrade Assistant's reindexing actions. Also updates\r\nsome
doc comments.\r\n\r\nClose
https://github.com/elastic/kibana/issues/121237\r\n\r\n<img
width=\"1163\" alt=\"Screenshot 2024-11-20 at 12 07
25\"\r\nsrc=\"https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Rudolf Meijering
<[email protected]>","sha":"3a6224f8594fa21a5f37a94542523fa6b77f2149"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@jloleysens @rudolf @paulinashakirova
[UA] Fix reindex docs in README.md (elastic#200893)
e6d0ac3 
## Summary

Updates overview of Upgrade Assistant's reindexing actions. Also updates
some doc comments.

Close elastic#121237

<img width="1163" alt="Screenshot 2024-11-20 at 12 07 25"
src="https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648">

---------

Co-authored-by: Rudolf Meijering <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@jloleysens @rudolf @CAWilson94
[UA] Fix reindex docs in README.md (elastic#200893)
f422386 
## Summary

Updates overview of Upgrade Assistant's reindexing actions. Also updates
some doc comments.

Close elastic#121237

<img width="1163" alt="Screenshot 2024-11-20 at 12 07 25"
src="https://github.com/user-attachments/assets/2b16e6e2-cee9-456b-b854-26ee658c3648">

---------

Co-authored-by: Rudolf Meijering <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Assistant README reindexing steps are inaccurate
5 participants
@jloleysens @elasticmachine @kibanamachine @sabarasaba @rudolf