Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search rename to elasticsearch #200774

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 19, 2024

This renames the Search solution to Elasticsearch to fit with our rebranding efforts.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v8.18.0 labels Nov 19, 2024
@sphilipse sphilipse requested review from a team as code owners November 19, 2024 16:50
@sphilipse sphilipse added the backport:version Backport to applied version labels label Nov 19, 2024
@@ -31,7 +31,7 @@ export interface DynamicSideNavItems {
const title = i18n.translate(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have this use the SEARCH_PRODUCT_NAME constant so it always matches classic nav which uses that too.

@TattdCodeMonkey
Copy link
Contributor

Note to self, I need to align #200314 to have these changes as well.

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbn-management changes lgtm

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / aiops change point detection attaches change point charts to a case

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 37.0KB 37.0KB +7.0B
alerting 94.0KB 94.0KB +7.0B
apm 3.4MB 3.4MB +7.0B
enterpriseSearch 2.6MB 2.6MB +7.0B
home 152.1KB 152.1KB +14.0B
infra 1.7MB 1.7MB +7.0B
observability 472.5KB 472.5KB +7.0B
observabilityAiAssistantManagement 93.1KB 93.1KB +7.0B
profiling 406.1KB 406.1KB +7.0B
securitySolution 13.4MB 13.4MB +7.0B
spaces 257.7KB 257.7KB +28.0B
telemetryManagementSection 33.6KB 33.6KB +7.0B
total +112.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 454.0KB 454.0KB +7.0B
customIntegrations 10.1KB 10.2KB +7.0B
enterpriseSearch 53.8KB 53.8KB +7.0B
esUiShared 106.9KB 106.9KB +7.0B
fleet 174.1KB 174.1KB +7.0B
observabilityShared 93.6KB 93.6KB +7.0B
spaces 34.4KB 34.4KB +7.0B
triggersActionsUi 128.8KB 128.8KB +7.0B
total +56.0B

History

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet code LGTM

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sphilipse sphilipse merged commit 0cafc7b into elastic:main Nov 20, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11938401378

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
This renames the Search solution to Elasticsearch to fit with our
rebranding efforts.

(cherry picked from commit 0cafc7b)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 The branch "8.18" does not exist
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 200774

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Search rename to elasticsearch
(#200774)](#200774)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T17:14:26Z","message":"Search
rename to elasticsearch (#200774)\n\nThis renames the Search solution to
Elasticsearch to fit with our\r\nrebranding
efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"title":"Search
rename to
elasticsearch","number":200774,"url":"https://github.com/elastic/kibana/pull/200774","mergeCommit":{"message":"Search
rename to elasticsearch (#200774)\n\nThis renames the Search solution to
Elasticsearch to fit with our\r\nrebranding
efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200774","number":200774,"mergeCommit":{"message":"Search
rename to elasticsearch (#200774)\n\nThis renames the Search solution to
Elasticsearch to fit with our\r\nrebranding
efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
This renames the Search solution to Elasticsearch to fit with our
rebranding efforts.
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
This renames the Search solution to Elasticsearch to fit with our
rebranding efforts.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
This renames the Search solution to Elasticsearch to fit with our
rebranding efforts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants