-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search rename to elasticsearch #200774
Search rename to elasticsearch #200774
Conversation
@@ -31,7 +31,7 @@ export interface DynamicSideNavItems { | |||
const title = i18n.translate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could have this use the SEARCH_PRODUCT_NAME
constant so it always matches classic nav which uses that too.
Note to self, I need to align #200314 to have these changes as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kbn-management changes lgtm
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
Page load bundle
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Starting backport for target branches: 8.18, 8.x |
This renames the Search solution to Elasticsearch to fit with our rebranding efforts. (cherry picked from commit 0cafc7b)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [Search rename to elasticsearch (#200774)](#200774) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T17:14:26Z","message":"Search rename to elasticsearch (#200774)\n\nThis renames the Search solution to Elasticsearch to fit with our\r\nrebranding efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0"],"title":"Search rename to elasticsearch","number":200774,"url":"https://github.com/elastic/kibana/pull/200774","mergeCommit":{"message":"Search rename to elasticsearch (#200774)\n\nThis renames the Search solution to Elasticsearch to fit with our\r\nrebranding efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200774","number":200774,"mergeCommit":{"message":"Search rename to elasticsearch (#200774)\n\nThis renames the Search solution to Elasticsearch to fit with our\r\nrebranding efforts.","sha":"0cafc7be9eadc97bfe9d93e169a2b25e55c1afa1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
This renames the Search solution to Elasticsearch to fit with our rebranding efforts.
This renames the Search solution to Elasticsearch to fit with our rebranding efforts.
This renames the Search solution to Elasticsearch to fit with our rebranding efforts.
This renames the Search solution to Elasticsearch to fit with our rebranding efforts.