Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] Filter integrations/packages list shown depending on the `policy_templates_behavior` field (#200605) #200749

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…icy_templates_behavior` field (elastic#200605)

## Summary
Closes elastic#198145

Add support to filter the tiles shown in the integrations UI as well as
the packages shown in the global search provider depending on the
`policy_templates_behaviour` field introduced in
elastic/package-spec#802.

If this new field is not present in the package manifest, the same
behavior is kept. Therefore, it is shown a tile for the package itself
plus a tile for each policy template defined in the manifest.

Tested using a custom Elastic Package Registry with some packages
defining this new `policy_templates_behavior` via the key:
```yaml
xpack.fleet.registryUrl: http://localhost:8080
```

### Screenshots

Checked option "Elastic Agent only" in the integrations UI to avoid
tutorials based on Beats.

Example with `azure_metrics` package in the Integrations UI:
- `policy_templates_behavior: all`
![All policy
templates](https://github.com/user-attachments/assets/907618e3-f2db-44df-b1ac-3965b1978b2c)

- `policy_templates_behavior: combined_policy`
![Just combined
policy](https://github.com/user-attachments/assets/77293616-8125-4d01-81f3-b3f17135ca49)

- `policy_templates_behavior: individual_policies`
![Just individual policy
templates](https://github.com/user-attachments/assets/b68ad474-8aac-464b-9946-9ae6104dd2ae)

Example in the Global Search with `azure_metrics` package and `combined
policy` behavior:
![global search with azure metrics
package](https://github.com/user-attachments/assets/e70315b7-d303-4b32-aa9e-8e1e9b056239)

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ]

(cherry picked from commit 8352b86)
@kibanamachine kibanamachine enabled auto-merge (squash) November 19, 2024 14:32
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / filterPolicyTemplatesTiles should return all tiles
  • [job] [logs] Jest Tests #7 / filterPolicyTemplatesTiles should return all tiles
  • [job] [logs] FTR Configs #36 / home app Welcome interstitial clicking on "Explore on my own" redirects to the "home" page
  • [job] [logs] Jest Tests #7 / Package search provider #find tags with integration tag, with policy_templates_behavior field
  • [job] [logs] Jest Tests #7 / Package search provider #find tags with integration tag, with policy_templates_behavior field
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy (16 result)
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy and unhealthy
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

History

cc @mrodm

@kibanamachine kibanamachine merged commit 4a9f70d into elastic:8.x Nov 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants