Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Search:Search Applications:Content page]Missing error text for Select searchable indices field #200736

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix: [Search:Search Applications:Content page]Missing error text for Select searchable indices field #200736

merged 4 commits into from
Nov 21, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 19, 2024 •
edited by kibanamachine
Loading

Closes: #200141
Closes: #199815

Description

Fields which are in error should have error text that for user it should be instantly clear what is the error and how to fix it.

What was changed:

  1. Error handling was added for applications/components/indices_select_combobox.tsx component

Screen

image

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility labels Nov 19, 2024
@alexwizp alexwizp marked this pull request as ready for review November 19, 2024 18:11
@alexwizp alexwizp requested a review from a team as a code owner November 19, 2024 18:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elastic elastic deleted a comment from elasticmachine Nov 19, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / #getDataUsageMetricsFiltersFromUrlParams should use given relative startDate and endDate values URL params

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +406.0B

@alexwizp alexwizp merged commit 0abcf06 into elastic:main Nov 21, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11957706413

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@alexwizp
fix: [Search:Search Applications:Content page]Missing error text for …
fe2dc8b 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed:
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">

(cherry picked from commit 0abcf06)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:Search Applications:Content page]Missing error tex…
9fba1fa 
…t for Select searchable indices field (#200736) (#201241)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:Search Applications:Content page]Missing error text for
Select searchable indices field
(#200736)](#200736)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:41:47Z","message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices
field","number":200736,"url":"https://github.com/elastic/kibana/pull/200736","mergeCommit":{"message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200736","number":200736,"mergeCommit":{"message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@alexwizp @paulinashakirova
fix: [Search:Search Applications:Content page]Missing error text for …
dc1f857 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141 
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed: 
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@alexwizp @CAWilson94
fix: [Search:Search Applications:Content page]Missing error text for …
58c7fc8 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141 
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed: 
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
4 participants
@alexwizp @elasticmachine @kibanamachine @sphilipse