Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Attack discovery] Updates Attack discovery directory structure #200613

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[Security Solution] [Attack discovery] Updates Attack discovery directory structure #200613

merged 1 commit into from
Nov 18, 2024

Conversation

andrew-goldstein
Copy link
Contributor

@andrew-goldstein andrew-goldstein commented Nov 18, 2024 •
edited by kibanamachine
Loading

[Security Solution] [Attack discovery] Updates Attack discovery directory structure

This PR updates the Attack discovery directory structure to align it with the latest implementation.

The scope of this update is limited to file paths and imports.

@andrew-goldstein andrew-goldstein added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v8.17.0 labels Nov 18, 2024
@andrew-goldstein andrew-goldstein self-assigned this Nov 18, 2024
@andrew-goldstein andrew-goldstein requested a review from a team as a code owner November 18, 2024 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

stephmilovic
stephmilovic approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are as described. Ran through AD workflow locally and all works as expected. Thanks for your efforts to keep the code organized. LGTM

@andrew-goldstein
### [Security Solution] [Attack discovery] Updates Attack discovery d…
fd220d3 
…irectory structure

This PR updates the Attack discovery directory structure to align it with the latest implementation.

The scope of this update is limited to file paths and imports.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB -6.0B

History

cc @andrew-goldstein

@andrew-goldstein andrew-goldstein merged commit 974293f into elastic:main Nov 18, 2024
43 checks passed
@andrew-goldstein andrew-goldstein deleted the ad_directory_structure branch November 18, 2024 20:32
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11900600232

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2024
@andrew-goldstein
[Security Solution] [Attack discovery] Updates Attack discovery direc…
fec15cb 
…tory structure (elastic#200613)

### [Security Solution] [Attack discovery] Updates Attack discovery directory structure

This PR updates the Attack discovery directory structure to align it with the latest implementation.

The scope of this update is limited to file paths and imports.

(cherry picked from commit 974293f)
@kibanamachine kibanamachine mentioned this pull request Nov 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 18, 2024
Merged
kibanamachine added a commit that referenced this pull request Nov 18, 2024
@kibanamachine @andrew-goldstein
[8.x] [Security Solution] [Attack discovery] Updates Attack discovery…
6e90b7c 
… directory structure (#200613) (#200652)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] [Attack discovery] Updates Attack discovery
directory structure
(#200613)](#200613)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Andrew
Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T20:32:43Z","message":"[Security
Solution] [Attack discovery] Updates Attack discovery directory
structure (#200613)\n\n### [Security Solution] [Attack discovery]
Updates Attack discovery directory structure\r\n\r\nThis PR updates the
Attack discovery directory structure to align it with the latest
implementation.\r\n\r\nThe scope of this update is limited to file paths
and
imports.","sha":"974293fa0118c3f40bc4b39052f0141cb4f379ce","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v8.17.0"],"title":"[Security Solution] [Attack
discovery] Updates Attack discovery directory
structure","number":200613,"url":"https://github.com/elastic/kibana/pull/200613","mergeCommit":{"message":"[Security
Solution] [Attack discovery] Updates Attack discovery directory
structure (#200613)\n\n### [Security Solution] [Attack discovery]
Updates Attack discovery directory structure\r\n\r\nThis PR updates the
Attack discovery directory structure to align it with the latest
implementation.\r\n\r\nThe scope of this update is limited to file paths
and
imports.","sha":"974293fa0118c3f40bc4b39052f0141cb4f379ce"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200613","number":200613,"mergeCommit":{"message":"[Security
Solution] [Attack discovery] Updates Attack discovery directory
structure (#200613)\n\n### [Security Solution] [Attack discovery]
Updates Attack discovery directory structure\r\n\r\nThis PR updates the
Attack discovery directory structure to align it with the latest
implementation.\r\n\r\nThe scope of this update is limited to file paths
and
imports.","sha":"974293fa0118c3f40bc4b39052f0141cb4f379ce"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Andrew Macri <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@andrew-goldstein @CAWilson94
[Security Solution] [Attack discovery] Updates Attack discovery direc…
c4f2fc0 
…tory structure (elastic#200613)

### [Security Solution] [Attack discovery] Updates Attack discovery directory structure

This PR updates the Attack discovery directory structure to align it with the latest implementation.

The scope of this update is limited to file paths and imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@andrew-goldstein andrew-goldstein

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-goldstein @elasticmachine @kibanamachine @stephmilovic