Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Unskip feature flag test #200596

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Nov 18, 2024

closes #198998

Summary

Just unskips he APM feature flag serverless tests.

@crespocarlos
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7418

[✅] x-pack/test_serverless/api_integration/test_suites/observability/config.ts: 25/25 tests passed.

see run history

@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 19, 2024
@crespocarlos crespocarlos marked this pull request as ready for review November 19, 2024 14:01
@crespocarlos crespocarlos requested a review from a team as a code owner November 19, 2024 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to run the flaky test runner?

@crespocarlos
Copy link
Contributor Author

LGTM, do we need to run the flaky test runner?

yes. it passed: #200596 (comment)

@crespocarlos crespocarlos merged commit b46d93f into elastic:main Nov 19, 2024
28 checks passed
@crespocarlos crespocarlos deleted the 198998-unskip-feature_flags-test branch November 19, 2024 15:31
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11916354904

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
closes [elastic#198998](elastic#198998)

## Summary

Just unskips he APM feature flag serverless tests.

(cherry picked from commit b46d93f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 19, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Unskip feature flag test
(#200596)](#200596)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T15:31:12Z","message":"[APM]
Unskip feature flag test (#200596)\n\ncloses
[#198998](https://github.com/elastic/kibana/issues/198998)\r\n\r\n##
Summary\r\n\r\nJust unskips he APM feature flag serverless
tests.","sha":"b46d93fe152813f6e38343f90a81387cc1e073ff","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[APM]
Unskip feature flag
test","number":200596,"url":"https://github.com/elastic/kibana/pull/200596","mergeCommit":{"message":"[APM]
Unskip feature flag test (#200596)\n\ncloses
[#198998](https://github.com/elastic/kibana/issues/198998)\r\n\r\n##
Summary\r\n\r\nJust unskips he APM feature flag serverless
tests.","sha":"b46d93fe152813f6e38343f90a81387cc1e073ff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200596","number":200596,"mergeCommit":{"message":"[APM]
Unskip feature flag test (#200596)\n\ncloses
[#198998](https://github.com/elastic/kibana/issues/198998)\r\n\r\n##
Summary\r\n\r\nJust unskips he APM feature flag serverless
tests.","sha":"b46d93fe152813f6e38343f90a81387cc1e073ff"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
closes [elastic#198998](elastic#198998)

## Summary

Just unskips he APM feature flag serverless tests.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
closes [elastic#198998](elastic#198998)

## Summary

Just unskips he APM feature flag serverless tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v9.0.0
Projects
None yet
4 participants