Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient #200578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
release_note:skip
mikecote
commented
Nov 19, 2024
| @@ -248,13 +248,13 @@ function getHealthStatus( | |||
| return { status: HealthStatus.OK, reason }; | |||
| } | |||
|
|
|||
| if (assumedAverageRecurringRequiredThroughputPerMinutePerKibana < capacityPerMinutePerKibana) { | |||
| const reason = `Task Manager is unhealthy, the assumedAverageRecurringRequiredThroughputPerMinutePerKibana (${assumedAverageRecurringRequiredThroughputPerMinutePerKibana}) < capacityPerMinutePerKibana (${capacityPerMinutePerKibana})`; | |||
| if (assumedAverageRecurringRequiredThroughputPerMinutePerKibana > capacityPerMinutePerKibana) { | |||
There was a problem hiding this comment.
The logic was wrong, this should only log if we exceed capacityPerMinutePerKibana in this case.
mikecote
commented
Nov 19, 2024
| logger.warn(reason); | ||
| return { status: HealthStatus.OK, reason }; | ||
| } | ||
|
|
||
| const reason = `Task Manager is unhealthy, the assumedRequiredThroughputPerMinutePerKibana (${assumedRequiredThroughputPerMinutePerKibana}) >= capacityPerMinutePerKibana (${capacityPerMinutePerKibana}) AND assumedAverageRecurringRequiredThroughputPerMinutePerKibana (${assumedAverageRecurringRequiredThroughputPerMinutePerKibana}) >= capacityPerMinutePerKibana (${capacityPerMinutePerKibana})`; | ||
| const reason = `Task Manager is unhealthy, the assumedRequiredThroughputPerMinutePerKibana (${assumedRequiredThroughputPerMinutePerKibana}) >= capacityPerMinutePerKibana (${capacityPerMinutePerKibana})`; |
There was a problem hiding this comment.
Given the code above logs whenever something is wrong with assumedAverageRecurringRequiredThroughputPerMinutePerKibana, I'm removing it from the message here.
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]
History
cc @mikecote |
ymao1
approved these changes
Nov 22, 2024
|
Starting backport for target branches: 8.16, 8.17 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…ThroughputPerMinutePerKibana was sufficient (elastic#200578) In this PR, I'm fixing a bug where the task manager unhealthy logs were showing the wrong reason. Because the if condition was checking `assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less than `capacityPerMinutePerKibana`, it would log this as the reason task manager is healthy. However whenever the value is less, it means task manager is running fine from a recurring task perspective. Changing the if condition allows the next step in the code to log which then logs `assumedRequiredThroughputPerMinutePerKibana` as the real reason why task manager is unhealthy. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9fa8ec7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…ThroughputPerMinutePerKibana was sufficient (elastic#200578) In this PR, I'm fixing a bug where the task manager unhealthy logs were showing the wrong reason. Because the if condition was checking `assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less than `capacityPerMinutePerKibana`, it would log this as the reason task manager is healthy. However whenever the value is less, it means task manager is running fine from a recurring task perspective. Changing the if condition allows the next step in the code to log which then logs `assumedRequiredThroughputPerMinutePerKibana` as the real reason why task manager is unhealthy. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9fa8ec7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…equiredThroughputPerMinutePerKibana was sufficient (#200578) (#201444) # Backport This will backport the following commits from `main` to `8.16`: - [Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)](#200578) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T17:33:43Z","message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient","number":200578,"url":"https://github.com/elastic/kibana/pull/200578","mergeCommit":{"message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200578","number":200578,"mergeCommit":{"message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mike Côté <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…equiredThroughputPerMinutePerKibana was sufficient (#200578) (#201445) # Backport This will backport the following commits from `main` to `8.17`: - [Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)](#200578) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T17:33:43Z","message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient","number":200578,"url":"https://github.com/elastic/kibana/pull/200578","mergeCommit":{"message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200578","number":200578,"mergeCommit":{"message":"Fix bug in capacity warning logs when assumedAverageRecurringRequiredThroughputPerMinutePerKibana was sufficient (#200578)\n\nIn this PR, I'm fixing a bug where the task manager unhealthy logs were\r\nshowing the wrong reason. Because the if condition was checking\r\n`assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less\r\nthan `capacityPerMinutePerKibana`, it would log this as the reason task\r\nmanager is healthy. However whenever the value is less, it means task\r\nmanager is running fine from a recurring task perspective. Changing the\r\nif condition allows the next step in the code to log which then logs\r\n`assumedRequiredThroughputPerMinutePerKibana` as the real reason why\r\ntask manager is unhealthy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9fa8ec71529faa31a44fe2eac0902fb0d4b98797"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mike Côté <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…ThroughputPerMinutePerKibana was sufficient (elastic#200578) In this PR, I'm fixing a bug where the task manager unhealthy logs were showing the wrong reason. Because the if condition was checking `assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less than `capacityPerMinutePerKibana`, it would log this as the reason task manager is healthy. However whenever the value is less, it means task manager is running fine from a recurring task perspective. Changing the if condition allows the next step in the code to log which then logs `assumedRequiredThroughputPerMinutePerKibana` as the real reason why task manager is unhealthy. --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ThroughputPerMinutePerKibana was sufficient (elastic#200578) In this PR, I'm fixing a bug where the task manager unhealthy logs were showing the wrong reason. Because the if condition was checking `assumedAverageRecurringRequiredThroughputPerMinutePerKibana` to be less than `capacityPerMinutePerKibana`, it would log this as the reason task manager is healthy. However whenever the value is less, it means task manager is running fine from a recurring task perspective. Changing the if condition allows the next step in the code to log which then logs `assumedRequiredThroughputPerMinutePerKibana` as the real reason why task manager is unhealthy. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm fixing a bug where the task manager unhealthy logs were showing the wrong reason. Because the if condition was checking
assumedAverageRecurringRequiredThroughputPerMinutePerKibanato be less thancapacityPerMinutePerKibana, it would log this as the reason task manager is healthy. However whenever the value is less, it means task manager is running fine from a recurring task perspective. Changing the if condition allows the next step in the code to log which then logsassumedRequiredThroughputPerMinutePerKibanaas the real reason why task manager is unhealthy.