Clean code related to savedObjectClientContrat that wasn't being used #200577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesuswr
added
Feature:Saved Objects
release_note:skip
## Summary Update FTR docs both in `x-pack/test_serverless` and `x-pack/test/api_integration/deployment_agnostic/` paths to show relevant example for authentication with Cookie header.
…9984) ## Summary Closes elastic#198983 Part of elastic#193245 This PR contains the changes to migrate `service_maps` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [ ] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Assign test files to ml-ui team Contributes to: elastic#192979 --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Graham Hudgins <[email protected]> Co-authored-by: Irene Blanco <[email protected]> Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Dmitrii Shevchenko <[email protected]> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Ania Kowalska <[email protected]> Co-authored-by: Milosz Marcinkowski <[email protected]> Co-authored-by: Sergi Romeu <[email protected]> Co-authored-by: Nathan Reese <[email protected]> Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Viduni Wickramarachchi <[email protected]> Co-authored-by: wajihaparvez <[email protected]>
## Summary This PR fixes styling for `KQL parsing error` text on various elements on `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on new line. Closes: elastic#49377     --------- Co-authored-by: kibanamachine <[email protected]>
## Summary This PR adds basic support for theme switching to test experimental themes internally. It defines a new `theme:name` setting which is read-only (and thus hidden) by default, and needs `uiSettings.experimental.themeSwitcherEnabled: true` config setting to become visible. The implementation and the way the theme switcher feature is enabled will likely change in the upcoming weeks when we iron out the details, but the way it works right now is sufficient for testing and that's what the immediate goal is. Please note this PR includes mostly setup work, and no additional themes have been added here. To make reviewing slightly easier, these will be added separately. The feature and settings should be undocumented for the time being and disabled by default. --- As you might notice, there's a new setting added despite already having `theme:version`. We decided to introduce a new setting instead of resurrecting an existing one for better naming and flexibility and to reduce the risk of breaking things that might still use the old setting value (hardcoded to `v8` at the moment). The current plan is to remove `theme:version` in 9.0. The theme_loader got refactored to only bundle active themes coming from `KBN_OPTIMIZER_THEMES` (defaulting to `v8light` and `v8dark`) instead of `ALL_THEMES` that would significantly increase bundle sizes even when the experimental themes were not enabled. Considering there's a SASS to CSS-in-JS migration happening right now, we don't need to worry about Kibana bundles growing in size when a new theme is officially added. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Clint Andrew Hall <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
## Summary Assign test files to obs-ux-management-team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]>
…stic#200156) ## Summary Assign test files to obs-ux-infra_services-team team Contributes to: elastic#192979
## Summary Assign test files to obs-ux-logs team Contributes to: elastic#192979
…gnostic API tests (elastic#200140) closes elastic#198990 part of elastic#193245 ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` - [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Checklist - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] serverless - [x] stateful - [x] MKI --------- Co-authored-by: kibanamachine <[email protected]>
…9735) ## Summary This PR makes it so `pie` is used over `donut` as default suggestion. If something is a `donut` already, adding another ring won't switch to `pie`. Closes: elastic#101289
## Summary Assign test files to platform docs team Contributes to: elastic#192979 Co-authored-by: Elastic Machine <[email protected]>
## Summary Assign test files to ops team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
## Summary Trying to answer the question of: "Do we still need `timeline.isLoading`?" `timeline.isSaving` should be the only indicator for "loading" states of timeline itself. All other pieces of state that are associated with timeline that could have a loading state, have their own loading indicators (e.g. data providers, alert list etc). Therefore, this PR removes all references to `timeline.isLoading` and parts of the UI that depended on it. Places that `timeline.isLoading` was used ([context](elastic#38185)): - Blocking drag/drop on data providers - This is not necessary anymore. Drag/drop works while the underlying query is being executed. - Showing a loading state for the alerts table & data provider changes - Both components have their own loading state, so no extra loading state is necessary ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
Closes elastic#200190 ## Summary This PR fixes the issue with the errors shown on the metrics explorer page - when the metrics indices can't be fetched we should show the error returned and if there is no fetch error and a remote cluster configured but no connection is possible we should show the remote cluster error: - Example with 504 error  - Example with remote cluster error  ## Testing Couldn't find a way to reproduce this so I "faked" the API response to be an error and checked several cases - API returns an error, we should show the error: https://github.com/user-attachments/assets/c1086b22-1ff5-4333-97a5-b3d1dca16afe - API doesn't return an error but the remote cluster connection wasn't possible, we should show the remote cluster error: https://github.com/user-attachments/assets/151b3ae4-5ca1-4d54-bd58-2729db202cdb - If no remote cluster is used/or a remote cluster is connected and the API response is not returning an error the page should load correctly: https://github.com/user-attachments/assets/f9ef1066-3dfd-4957-8b46-878bf58d2f1c
## Summary Assign test files to apm teams Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
## Summary Assign test files to stack-monitoring team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Assign test files to observability-ui team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This PR adds a Signer condition for trusted apps on macOS. Previously, users could only build conditions using hash, path, and signer options on Windows. With these changes, macOS also supports the Signer option, leaving only Linux limited to Path and Hash options. https://github.com/user-attachments/assets/ea8fb734-7884-451d-8873-e3a29861876b
jesuswr
requested review from
ashokaditya,
gergoabraham,
hop-dev,
xcrzx and
rylnd
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
cc @jesuswr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #197216
Removed all code that wasn't being used in https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.
Didn't remove the actual client since it's still being used here:
kibana/src/plugins/home/public/application/kibana_services.ts
Lines 46 to 48 in dbab221
Checked everything with
node scripts/type_checkChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_node:*label is applied per the guidelines