Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Flags] Set RUM transaction.outcome #200576

Merged
merged 4 commits into from
Nov 21, 2024
Merged

[Feature Flags] Set RUM transaction.outcome #200576

merged 4 commits into from
Nov 21, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 18, 2024 •
edited by kibanamachine
Loading

Summary

Reporting the success/failure state of the feature-flags.set-provider transactions. It's been confirmed that's not documented, but doable: Slack

@afharo afharo self-assigned this Nov 18, 2024
@afharo afharo requested a review from a team as a code owner November 18, 2024 14:23
@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Configuration Settings in kibana.yml backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

jloleysens
jloleysens approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @afharo , only nit: a unit test would nice

@afharo
Copy link
Member Author

afharo commented Nov 21, 2024

Tests added! :)

@afharo afharo enabled auto-merge (squash) November 21, 2024 10:34
@afharo afharo merged commit f9287a9 into elastic:main Nov 21, 2024
24 checks passed
@afharo afharo deleted the rum-transaction-outcome branch November 21, 2024 15:40
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11956635779

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / UserActionsList renders list correctly with isExpandable option
  • [job] [logs] Jest Tests #17 / useUpdateTags should call onSuccess when bulk update tags succeeds

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 454.2KB 454.2KB +28.0B

History

cc @afharo

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 200576

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200576 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 22, 2024
@afharo afharo removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 23, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 25, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200576 locally

@afharo afharo mentioned this pull request Nov 25, 2024
Merged
@afharo
Copy link
Member Author

afharo commented Nov 25, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

afharo added a commit that referenced this pull request Nov 25, 2024
@afharo
[8.x] [Feature Flags] Set RUM transaction.outcome (#200576) (#201526)
c9e9748 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Feature Flags] Set RUM transaction.outcome
(#200576)](#200576)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T15:40:52Z","message":"[Feature
Flags] Set RUM transaction.outcome
(#200576)","sha":"f9287a954581113e0d4cbf5f90ac4eb2a19b7c69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Configuration","backport
missing","v9.0.0","backport:prev-minor"],"number":200576,"url":"https://github.com/elastic/kibana/pull/200576","mergeCommit":{"message":"[Feature
Flags] Set RUM transaction.outcome
(#200576)","sha":"f9287a954581113e0d4cbf5f90ac4eb2a19b7c69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200576","number":200576,"mergeCommit":{"message":"[Feature
Flags] Set RUM transaction.outcome
(#200576)","sha":"f9287a954581113e0d4cbf5f90ac4eb2a19b7c69"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 25, 2024
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@afharo @paulinashakirova
[Feature Flags] Set RUM transaction.outcome (elastic#200576)
1fbd908
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@afharo @CAWilson94
[Feature Flags] Set RUM transaction.outcome (elastic#200576)
d1ed666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees

@afharo afharo

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Configuration Settings in kibana.yml release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afharo @elasticmachine @kibanamachine @jloleysens