fix: Change "Single Account" to "Single Project" in button text #200327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
Hi @samantha-t28! Thanks a lot for contributing with your PR! Could you please add a link to the original issue in the description? I recommend you as well replacing the placeholder text ("Summarize your PR. If it involves visual changes include a screenshot or gif.") with a very brief summary that describes the change and motivation. Also, I saw in the screenshots you changed the button's copy but the paragraph above still says "single account". Would you mind changing that as well to keep copy consistent across the UI? 
|
|
Hi @albertoblaz, I’ve added the original issue link to the description and included a brief summary and motivation for clarity. Additionally, I’ve updated the paragraph above the button from "Single Account" to "Single Project". Please let me know if there’s anything I might have missed or needs adjustment 🙂 |
albertoblaz
added
release_note:skip
maxcold
approved these changes
Nov 19, 2024
albertoblaz
approved these changes
Nov 19, 2024
|
/ci |
💚 Build Succeeded
Metrics [docs]
|
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
…tic#200327) ## Summary This pull request resolves [elastic#198879](elastic#198879), where "Single Account" was incorrectly displayed in the GCP integration screen. The text has been updated to "Single Project" to align with GCP terminology. Additionally, the paragraph above this text was updated to ensure consistency across the UI. ## Motivation Aligning the GCP integration screen with GCP’s correct terminology by replacing "Single Account" with "Single Project" ensures clarity and consistency across the UI. ## Screenshots: **Before**: interface showing "Single Account" <img width="858" alt="Screenshot 2024-11-18 at 1 29 18 PM" src="https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d"> **After**: updated interface showing "Single Project" <img width="782" alt="Screenshot 2024-11-18 at 1 29 57 PM" src="https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - [ ] ~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - [ ] ~~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - [ ] ~~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Maxim Kholod <[email protected]> (cherry picked from commit a5831c0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
…quot; in button text (#200327) (#200813) # Backport This will backport the following commits from `main` to `8.x`: - [fix: Change "Single Account" to "Single Project" in button text (#200327)](#200327) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samantha Tan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T19:38:13Z","message":"fix: Change \"Single Account\" to \"Single Project\" in button text (#200327)\n\n## Summary\r\n\r\nThis pull request resolves\r\n[#198879](#198879), where\r\n\"Single Account\" was incorrectly displayed in the GCP integration\r\nscreen. The text has been updated to \"Single Project\" to align with GCP\r\nterminology. Additionally, the paragraph above this text was updated to\r\nensure consistency across the UI.\r\n\r\n## Motivation\r\n\r\nAligning the GCP integration screen with GCP’s correct terminology by\r\nreplacing \"Single Account\" with \"Single Project\" ensures clarity and\r\nconsistency across the UI.\r\n\r\n## Screenshots:\r\n**Before**: interface showing \"Single Account\"\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-11-18 at 1 29 18 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d\">\r\n\r\n**After**: updated interface showing \"Single Project\"\r\n\r\n<img width=\"782\" alt=\"Screenshot 2024-11-18 at 1 29 57 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2\">\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~~\r\n- [ ] ~~[Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios~~\r\n- [ ] ~~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\r\n- [ ] ~~This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.~~\r\n- [ ] ~~[Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed~~\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"a5831c0d2346d7ea7b95cb0516ff67da46b9d68b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","backport:prev-minor","backport:version","v8.17.0"],"title":"fix: Change \"Single Account\" to \"Single Project\" in button text","number":200327,"url":"https://github.com/elastic/kibana/pull/200327","mergeCommit":{"message":"fix: Change \"Single Account\" to \"Single Project\" in button text (#200327)\n\n## Summary\r\n\r\nThis pull request resolves\r\n[#198879](#198879), where\r\n\"Single Account\" was incorrectly displayed in the GCP integration\r\nscreen. The text has been updated to \"Single Project\" to align with GCP\r\nterminology. Additionally, the paragraph above this text was updated to\r\nensure consistency across the UI.\r\n\r\n## Motivation\r\n\r\nAligning the GCP integration screen with GCP’s correct terminology by\r\nreplacing \"Single Account\" with \"Single Project\" ensures clarity and\r\nconsistency across the UI.\r\n\r\n## Screenshots:\r\n**Before**: interface showing \"Single Account\"\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-11-18 at 1 29 18 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d\">\r\n\r\n**After**: updated interface showing \"Single Project\"\r\n\r\n<img width=\"782\" alt=\"Screenshot 2024-11-18 at 1 29 57 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2\">\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~~\r\n- [ ] ~~[Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios~~\r\n- [ ] ~~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\r\n- [ ] ~~This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.~~\r\n- [ ] ~~[Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed~~\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"a5831c0d2346d7ea7b95cb0516ff67da46b9d68b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200327","number":200327,"mergeCommit":{"message":"fix: Change \"Single Account\" to \"Single Project\" in button text (#200327)\n\n## Summary\r\n\r\nThis pull request resolves\r\n[#198879](#198879), where\r\n\"Single Account\" was incorrectly displayed in the GCP integration\r\nscreen. The text has been updated to \"Single Project\" to align with GCP\r\nterminology. Additionally, the paragraph above this text was updated to\r\nensure consistency across the UI.\r\n\r\n## Motivation\r\n\r\nAligning the GCP integration screen with GCP’s correct terminology by\r\nreplacing \"Single Account\" with \"Single Project\" ensures clarity and\r\nconsistency across the UI.\r\n\r\n## Screenshots:\r\n**Before**: interface showing \"Single Account\"\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-11-18 at 1 29 18 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d\">\r\n\r\n**After**: updated interface showing \"Single Project\"\r\n\r\n<img width=\"782\" alt=\"Screenshot 2024-11-18 at 1 29 57 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2\">\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~~\r\n- [ ] ~~[Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios~~\r\n- [ ] ~~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\r\n- [ ] ~~This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.~~\r\n- [ ] ~~[Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed~~\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"a5831c0d2346d7ea7b95cb0516ff67da46b9d68b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samantha Tan <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…tic#200327) ## Summary This pull request resolves [elastic#198879](elastic#198879), where "Single Account" was incorrectly displayed in the GCP integration screen. The text has been updated to "Single Project" to align with GCP terminology. Additionally, the paragraph above this text was updated to ensure consistency across the UI. ## Motivation Aligning the GCP integration screen with GCP’s correct terminology by replacing "Single Account" with "Single Project" ensures clarity and consistency across the UI. ## Screenshots: **Before**: interface showing "Single Account" <img width="858" alt="Screenshot 2024-11-18 at 1 29 18 PM" src="https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d"> **After**: updated interface showing "Single Project" <img width="782" alt="Screenshot 2024-11-18 at 1 29 57 PM" src="https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - [ ] ~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - [ ] ~~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - [ ] ~~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Maxim Kholod <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…tic#200327) ## Summary This pull request resolves [elastic#198879](elastic#198879), where "Single Account" was incorrectly displayed in the GCP integration screen. The text has been updated to "Single Project" to align with GCP terminology. Additionally, the paragraph above this text was updated to ensure consistency across the UI. ## Motivation Aligning the GCP integration screen with GCP’s correct terminology by replacing "Single Account" with "Single Project" ensures clarity and consistency across the UI. ## Screenshots: **Before**: interface showing "Single Account" <img width="858" alt="Screenshot 2024-11-18 at 1 29 18 PM" src="https://github.com/user-attachments/assets/c03cb5f0-8e30-4e90-852d-aa2e91d6918d"> **After**: updated interface showing "Single Project" <img width="782" alt="Screenshot 2024-11-18 at 1 29 57 PM" src="https://github.com/user-attachments/assets/2d1b3e09-8da8-401a-b711-34934c31a1b2"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - [ ] ~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - [ ] ~~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - [ ] ~~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Maxim Kholod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #198879, where "Single Account" was incorrectly displayed in the GCP integration screen. The text has been updated to "Single Project" to align with GCP terminology. Additionally, the paragraph above this text was updated to ensure consistency across the UI.
Motivation
Aligning the GCP integration screen with GCP’s correct terminology by replacing "Single Account" with "Single Project" ensures clarity and consistency across the UI.
Screenshots:
Before: interface showing "Single Account"
After: updated interface showing "Single Project"
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.Flaky Test Runner was used on any tests changedrelease_node:*label is applied per the guidelines