🌊 Play nice with ES #200253
Merged
🌊 Play nice with ES #200253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
There was a problem hiding this comment.
LGTM!
I endable streams, created 3 forks (logs.mongodb, logs.nginx, logs.nginx.errors), create a user that only had read and view_index_metadata for both logs and logs.mongodb, logged in as that user to ensure I could only see logs and logs.mongodb when calling GET /api/streams.
simianhacker
approved these changes
Nov 22, 2024
|
I think we will need to get back to https://github.com/elastic/kibana/pull/200253/files#diff-e247f45f35fcc0ed73b1992cf1c79d1b49257ea2fb8b763188d79458c22c1557R101 at some point - this strategy won't scale well. I will check with the Elasticsearch team. It should be fine for a first version though. |
dgieselaar
approved these changes
Nov 25, 2024
…/kibana into flash1293/streams-improvements
💚 Build Succeeded
Metrics [docs]
History
|
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
This PR implements two changes: * When syncing a stream, try to PUT the current mappings to the data stream - if this fails with `illegal_argument_exception`, do a rollover instead. This is similar to how fleet handles this situation * Before accessing streams, check whether the current user can read the current data stream and only return it if this is the case. Users with partial read access will only see a partial tree. This doesn't apply to writing changes as the user needs to be able to change index templates, pipelines and so on which requires admin privileges anyway --------- Co-authored-by: kibanamachine <[email protected]>
flash1293
added
backport:prev-minor
|
Starting backport for target branches: 8.17, 8.x |
|
Starting backport for target branches: 8.17, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
This PR implements two changes: * When syncing a stream, try to PUT the current mappings to the data stream - if this fails with `illegal_argument_exception`, do a rollover instead. This is similar to how fleet handles this situation * Before accessing streams, check whether the current user can read the current data stream and only return it if this is the case. Users with partial read access will only see a partial tree. This doesn't apply to writing changes as the user needs to be able to change index templates, pipelines and so on which requires admin privileges anyway --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 8e67172)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Play nice with ES (#200253)](#200253) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T06:46:36Z","message":"🌊 Play nice with ES (#200253)\n\nThis PR implements two changes:\r\n* When syncing a stream, try to PUT the current mappings to the data\r\nstream - if this fails with `illegal_argument_exception`, do a rollover\r\ninstead. This is similar to how fleet handles this situation\r\n* Before accessing streams, check whether the current user can read the\r\ncurrent data stream and only return it if this is the case. Users with\r\npartial read access will only see a partial tree. This doesn't apply to\r\nwriting changes as the user needs to be able to change index templates,\r\npipelines and so on which requires admin privileges anyway\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"8e671728614012a5f5c5efc68975d9c0139ccfb7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"🌊 Play nice with ES","number":200253,"url":"https://github.com/elastic/kibana/pull/200253","mergeCommit":{"message":"🌊 Play nice with ES (#200253)\n\nThis PR implements two changes:\r\n* When syncing a stream, try to PUT the current mappings to the data\r\nstream - if this fails with `illegal_argument_exception`, do a rollover\r\ninstead. This is similar to how fleet handles this situation\r\n* Before accessing streams, check whether the current user can read the\r\ncurrent data stream and only return it if this is the case. Users with\r\npartial read access will only see a partial tree. This doesn't apply to\r\nwriting changes as the user needs to be able to change index templates,\r\npipelines and so on which requires admin privileges anyway\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"8e671728614012a5f5c5efc68975d9c0139ccfb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200253","number":200253,"mergeCommit":{"message":"🌊 Play nice with ES (#200253)\n\nThis PR implements two changes:\r\n* When syncing a stream, try to PUT the current mappings to the data\r\nstream - if this fails with `illegal_argument_exception`, do a rollover\r\ninstead. This is similar to how fleet handles this situation\r\n* Before accessing streams, check whether the current user can read the\r\ncurrent data stream and only return it if this is the case. Users with\r\npartial read access will only see a partial tree. This doesn't apply to\r\nwriting changes as the user needs to be able to change index templates,\r\npipelines and so on which requires admin privileges anyway\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"8e671728614012a5f5c5efc68975d9c0139ccfb7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joe Reuter <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
This PR implements two changes: * When syncing a stream, try to PUT the current mappings to the data stream - if this fails with `illegal_argument_exception`, do a rollover instead. This is similar to how fleet handles this situation * Before accessing streams, check whether the current user can read the current data stream and only return it if this is the case. Users with partial read access will only see a partial tree. This doesn't apply to writing changes as the user needs to be able to change index templates, pipelines and so on which requires admin privileges anyway --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two changes:
illegal_argument_exception, do a rollover instead. This is similar to how fleet handles this situation