Respect system dark mode in ESQL editor #200233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor uses dark mode. When `uiSettings.overrides.theme:darkMode: system` is set, the ESQL editor uses light mode, while the rest of the UI uses dark mode. Update the ESQL theme creation to create both light and dark variations of the theme at startup and use the theme in React component to determine which ESQL theme to use at runtime.
smith
added
backport:all-open
stratoula
added
v9.0.0
v8.17.0
backport:version
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
|
stratoula
approved these changes
Nov 18, 2024
eokoneyo
approved these changes
Nov 18, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
When `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor uses dark mode. When `uiSettings.overrides.theme:darkMode: system` is set, the ESQL editor uses light mode, while the rest of the UI uses dark mode. Update the ESQL theme creation to create both light and dark variations of the theme at startup and use the theme in React component to determine which ESQL theme to use at runtime. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit f48ded9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Respect system dark mode in ESQL editor (#200233)](#200233) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan L Smith","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:49:10Z","message":"Respect system dark mode in ESQL editor (#200233)\n\nWhen `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor\r\nuses dark mode.\r\n\r\nWhen `uiSettings.overrides.theme:darkMode: system` is set, the ESQL\r\neditor uses light mode, while the rest of the UI uses dark mode.\r\n\r\nUpdate the ESQL theme creation to create both light and dark variations\r\nof the theme at startup and use the theme in React component to\r\ndetermine which ESQL theme to use at runtime.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"f48ded9686505d63fe40427c26d6f2b22e462fa0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"Respect system dark mode in ESQL editor","number":200233,"url":"https://github.com/elastic/kibana/pull/200233","mergeCommit":{"message":"Respect system dark mode in ESQL editor (#200233)\n\nWhen `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor\r\nuses dark mode.\r\n\r\nWhen `uiSettings.overrides.theme:darkMode: system` is set, the ESQL\r\neditor uses light mode, while the rest of the UI uses dark mode.\r\n\r\nUpdate the ESQL theme creation to create both light and dark variations\r\nof the theme at startup and use the theme in React component to\r\ndetermine which ESQL theme to use at runtime.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"f48ded9686505d63fe40427c26d6f2b22e462fa0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200233","number":200233,"mergeCommit":{"message":"Respect system dark mode in ESQL editor (#200233)\n\nWhen `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor\r\nuses dark mode.\r\n\r\nWhen `uiSettings.overrides.theme:darkMode: system` is set, the ESQL\r\neditor uses light mode, while the rest of the UI uses dark mode.\r\n\r\nUpdate the ESQL theme creation to create both light and dark variations\r\nof the theme at startup and use the theme in React component to\r\ndetermine which ESQL theme to use at runtime.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"f48ded9686505d63fe40427c26d6f2b22e462fa0"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan L Smith <[email protected]>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
When `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor uses dark mode. When `uiSettings.overrides.theme:darkMode: system` is set, the ESQL editor uses light mode, while the rest of the UI uses dark mode. Update the ESQL theme creation to create both light and dark variations of the theme at startup and use the theme in React component to determine which ESQL theme to use at runtime. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
When `uiSettings.overrides.theme:darkMode: true` is set, the ESQL editor uses dark mode. When `uiSettings.overrides.theme:darkMode: system` is set, the ESQL editor uses light mode, while the rest of the UI uses dark mode. Update the ESQL theme creation to create both light and dark variations of the theme at startup and use the theme in React component to determine which ESQL theme to use at runtime. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
uiSettings.overrides.theme:darkMode: trueis set, the ESQL editor uses dark mode.When
uiSettings.overrides.theme:darkMode: systemis set, the ESQL editor uses light mode, while the rest of the UI uses dark mode.Update the ESQL theme creation to create both light and dark variations of the theme at startup and use the theme in React component to determine which ESQL theme to use at runtime.