Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fix documents table a11y #200232

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 14, 2024

Summary

This improves the accessibility of the documents table by:

  1. Adding header rows with titles
  2. Adding an accessible table description
  3. Adding an accessible popover to the field type icon

@sphilipse sphilipse removed the request for review from a team November 18, 2024 12:42
@sphilipse sphilipse enabled auto-merge (squash) November 18, 2024 12:42
@sphilipse sphilipse merged commit 79a26e3 into elastic:main Nov 18, 2024
28 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11895108608

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +753.0B
searchIndices 166.9KB 167.6KB +751.0B
searchPlayground 167.4KB 168.2KB +750.0B
serverlessSearch 338.8KB 339.6KB +753.0B
total +2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchPlayground 7.2KB 7.2KB -55.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2024
## Summary

This improves the accessibility of the documents table by:
1. Adding header rows with titles
2. Adding an accessible table description
3. Adding an accessible popover to the field type icon

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 79a26e3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2024
## Summary

This improves the accessibility of the documents table by:
1. Adding header rows with titles
2. Adding an accessible table description
3. Adding an accessible popover to the field type icon

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 79a26e3)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16
8.18 The branch "8.18" does not exist
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 200232

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 18, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Search fix documents table a11y
(#200232)](#200232)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:00:12Z","message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.18.0"],"title":"Search
fix documents table
a11y","number":200232,"url":"https://github.com/elastic/kibana/pull/200232","mergeCommit":{"message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200232","number":200232,"mergeCommit":{"message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 18, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Search fix documents table a11y
(#200232)](#200232)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:00:12Z","message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.18.0"],"title":"Search
fix documents table
a11y","number":200232,"url":"https://github.com/elastic/kibana/pull/200232","mergeCommit":{"message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200232","number":200232,"mergeCommit":{"message":"Search
fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves
the accessibility of the documents table by:\r\n1. Adding header rows
with titles\r\n2. Adding an accessible table description\r\n3. Adding an
accessible popover to the field type
icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
jesuswr pushed a commit to jesuswr/kibana that referenced this pull request Nov 18, 2024
## Summary

This improves the accessibility of the documents table by:
1. Adding header rows with titles
2. Adding an accessible table description
3. Adding an accessible popover to the field type icon

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

This improves the accessibility of the documents table by:
1. Adding header rows with titles
2. Adding an accessible table description
3. Adding an accessible popover to the field type icon

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v8.16.1 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants