-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search fix documents table a11y #200232
Merged
sphilipse
merged 6 commits into
elastic:main
from
sphilipse:search-fix-documents-table-a11y
Nov 18, 2024
Merged
Search fix documents table a11y #200232
sphilipse
merged 6 commits into
elastic:main
from
sphilipse:search-fix-documents-table-a11y
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
Team:Search
v8.16.0
backport:version
Backport to applied version labels
v8.17.0
v8.16.1
v8.18.0
labels
Nov 14, 2024
TattdCodeMonkey
approved these changes
Nov 14, 2024
Starting backport for target branches: 8.16, 8.18, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This improves the accessibility of the documents table by: 1. Adding header rows with titles 2. Adding an accessible table description 3. Adding an accessible popover to the field type icon --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 79a26e3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This improves the accessibility of the documents table by: 1. Adding header rows with titles 2. Adding an accessible table description 3. Adding an accessible popover to the field type icon --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 79a26e3)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [Search fix documents table a11y (#200232)](#200232) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:00:12Z","message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.18.0"],"title":"Search fix documents table a11y","number":200232,"url":"https://github.com/elastic/kibana/pull/200232","mergeCommit":{"message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200232","number":200232,"mergeCommit":{"message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Search fix documents table a11y (#200232)](#200232) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:00:12Z","message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.18.0"],"title":"Search fix documents table a11y","number":200232,"url":"https://github.com/elastic/kibana/pull/200232","mergeCommit":{"message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200232","number":200232,"mergeCommit":{"message":"Search fix documents table a11y (#200232)\n\n## Summary\r\n\r\nThis improves the accessibility of the documents table by:\r\n1. Adding header rows with titles\r\n2. Adding an accessible table description\r\n3. Adding an accessible popover to the field type icon\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"79a26e3fd2b2cb43468e378802788db4ef621976"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This improves the accessibility of the documents table by: 1. Adding header rows with titles 2. Adding an accessible table description 3. Adding an accessible popover to the field type icon --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary This improves the accessibility of the documents table by: 1. Adding header rows with titles 2. Adding an accessible table description 3. Adding an accessible popover to the field type icon --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Search
v8.16.0
v8.16.1
v8.17.0
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves the accessibility of the documents table by: