[Ownership] Assign test files to ml-ui team #200212

wayneseymour · 2024-11-14T16:12:36Z

Summary

Assign test files to ml-ui team

Contributes to: #192979

.github/CODEOWNERS

wayneseymour · 2024-11-14T17:04:38Z

peteharverson

Left a few comments about trying to order new additions with existing entries in this file. Otherwise as the file grows, it becomes harder to spot which paths are already included.

peteharverson · 2024-11-18T09:18:48Z

oas_docs/output/kibana.serverless.yaml

-                      When flapping detection is turned on, alerts that switch
-                      quickly between active and recovered states are identified
-                      as “flapping” and notifications are reduced.
+                    description: When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.


Did you mean to touch this file?

No it wasn't me, it was a ci auto commit.

peteharverson · 2024-11-18T09:18:55Z

oas_docs/output/kibana.yaml

-                      When flapping detection is turned on, alerts that switch
-                      quickly between active and recovered states are identified
-                      as “flapping” and notifications are reduced.
+                    description: When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.


Did you mean to touch this file?

No it wasn't me, it was a ci auto commit.

peteharverson · 2024-11-18T09:20:45Z

.github/CODEOWNERS

@@ -1318,6 +1318,10 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
 #CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation

 # Machine Learning
+/x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts @elastic/ml-ui


Could you please group this line with the /x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/ml/ file a few lines down.

peteharverson · 2024-11-18T09:22:00Z

.github/CODEOWNERS

+/x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts @elastic/ml-ui
+/x-pack/test/stack_functional_integration/apps/ml @elastic/ml-ui
+/x-pack/test/functional/fixtures/kbn_archiver/ml @elastic/ml-ui
+/x-pack/test/accessibility/apps/group2/ml_* @elastic/ml-ui
 /x-pack/test/api_integration/apis/file_upload @elastic/ml-ui
 /x-pack/test/accessibility/apps/group2/ml.ts  @elastic/ml-ui


Could you please group this file with the /x-pack/test/accessibility/apps/group2/ml.ts entry a few lines down.

peteharverson · 2024-11-18T09:23:00Z

.github/CODEOWNERS

@@ -1337,7 +1341,8 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
 /x-pack/test/api_integration/services/ml.ts @elastic/ml-ui

 # Additional plugins and packages maintained by the ML team.
-/test/examples/response_stream @elastic/ml-ui
+/x-pack/test/functional/services/aiops @elastic/ml-ui


Could you please group this file with the /x-pack/test/functional/services/transform/ entry a few lines down.

Adds `mailto:` as an allowed URL Url formatters in data views.

…9963) ### How to test Closes elastic#198977 Part of elastic#193245 This PR contains the changes to migrate `inspect` test folder to deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [ ] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless

…pty on windows (elastic#199791) ## Summary Bug: On Windows, we can't select TSV files or drag them to the file picker. This error happens because we have a validation for the file type, and for some reason, on Windows, it is an empty string 🤡 . I updated the file validation logic to allow empty strings for file types and added one extra value to the acceptable types, `.tsv`. So, when the mime type checks fail, it will accept any files with the `tsv` extension. I desk-tested it on Windows-edge, Windows-chrome, Mac-chrome and it works. ### How to test it? * ON A WINDOWS MACHINE * Open the security solution app and navigate to the entity store page * Drag a TSV file created on a Windows machine; the file should be accepted * Click on the "select file" button and select a TSV file created on a Windows machine * Both methods should allow you to select the file, and you should be able to proceed with the bulk upload #### Do I need to checkout your code and start kibana? If you are a lazy person like me, you can test the feature using the cloud deployment [here](https://kibana-pr-199791.kb.us-west2.gcp.elastic-cloud.com/app/security/entity_analytics_entity_store). You can get the login/password using Vault. The instructions are on the latest Cloud Deployment link, or ask me for credentials. #### What if I don't have a Windows machine? Buy one. I am kidding. 🤡 You can follow [this tutorial](https://github.com/elastic/security-team/blob/main/tools/sec-eng-prod/sep-vms/README.md#setup) to deploy it to gcloud, and connect to it using RDP. But If you are lazy like me, you can ask me for my Windows 11 cloud deployment credentials. _Obs. You need an app to access the cloud deployment via RDP. The "Windows App" can be easily downloaded from the App Store on Mac._ ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

## Summary This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.

## Summary Assign test files to Appex QA Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

## Summary Closes elastic#199754 by introducing more fine-grained version getters to get the base version (to resolve to the git tag in the repo), the actual version which might include the IAR suffix and the docker version which replaces + with . For testing, EA host and kubernetes as well as OTel host should be tested. See here: elastic#199758 (comment) --------- Co-authored-by: kibanamachine <[email protected]>

…e `_perform` upgrade API (elastic#199761) **Partially addresses:** elastic#171520 ## Summary This PR integrates Prebuilt Rules Customization UI functionality with the `/internal/detection_engine/prebuilt_rules/upgrade/_perform` Prebuilt Rules Customization upgrade API. > [!CAUTION] > This PR doesn't handle rule type changes. Prebuilt rule updates with rule type change consider having a NON SOLVABLE conflict and won't be upgraded neither individually nor in bulk. Addressing that task requires UI and functional changes and will be addressed in a separate PR. ## Details ## How to test - Clear Elasticsearch data - Run Elasticsearch and Kibana locally (do not open Kibana in a web browser) - Install an outdated version of the `security_detection_engine` Fleet package ```bash curl -X POST --user elastic:changeme -H 'Content-Type: application/json' -H 'kbn-xsrf: 123' -H "elastic-api-version: 2023-10-31" -d '{"force":true}' http://localhost:5601/kbn/api/fleet/epm/packages/security_detection_engine/8.14.1 ``` - Install prebuilt rules ```bash curl -X POST --user elastic:changeme -H 'Content-Type: application/json' -H 'kbn-xsrf: 123' -H "elastic-api-version: 1" -d '{"mode":"ALL_RULES"}' http://localhost:5601/kbn/internal/detection_engine/prebuilt_rules/installation/_perform ``` - Open `Detection Rules (SIEM)` Page -> `Rule Updates` - [ ] Check update functionality in a flyout - Pick a rule - Click on rule's name - Make changes to fields in incoming rule updates updates - Save field(s) changes - Press the `Update` button - [ ] Check table row rule update - Pick a rule - Click on rule's name - Make changes to fields in incoming rule updates updates - Save field(s) changes - Close the flyout - Press the `Update rule` button in the rule's table row - [ ] Check bulk rule update - Pick a few rules and for each of them do the next steps - Click on rule's name - Make changes to fields in incoming rule updates updates - Save field(s) changes - Close the flyout - After press the `Update All` button on the page - [ ] Check selected rules bulk update - Pick a few rules and for each of them do the next steps - Click on rule's name - Make changes to fields in incoming rule updates updates - Save field(s) changes - Close the flyout - After select the modified rule updates - Press the `Update N selected rule(s)` button on the page Co-authored-by: Dmitrii Shevchenko <[email protected]>

…00161) ## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of elastic#14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty.

## Summary Fix OAS snapshot --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

)

## Summary Assign test files to search kibana team Contributes to: elastic#192979

…astic#199645) closes elastic#198967 closes elastic#198985 part of elastic#193245 ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` - [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Checklist - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] serverless - [x] stateful - [x] MKI --------- Co-authored-by: Sergi Romeu <[email protected]>

Closes elastic#200037 defaultTheme$ is only used in storybooks. This PR removes defaultTheme$ and replaces it with theme$ available from core start mock.

elastic#200112)

…y tests (elastic#200022) Closes elastic#192222 ## Summary ### Problem The test appears to be flaky, potentially because the entries are not available at the time of retrieval. This cannot be reproduced locally or via the flaky test runner. (more details [here](elastic#196026 (comment))) ### Solution Add a retry when fetching the instructions and check whether the number of instructions returned by the API endpoint is the same number of instructions expected. ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed

## Summary Adding a Kibana-related breaking change found in the Security release notes.

…n-ml

wayneseymour · 2024-11-18T09:41:01Z

@elasticmachine merge upstream

peteharverson

Thanks for making those edits. LGTM

elasticmachine · 2024-11-18T11:31:39Z

💚 Build Succeeded

Buildkite Build
Commit: ab6aca6

Metrics [docs]

✅ unchanged

History

💔 Build #251467 failed 44e1a68
💔 Build #251417 failed 591f2f7

cc @wayneseymour

## Summary Assign test files to ml-ui team Contributes to: elastic#192979 --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Graham Hudgins <[email protected]> Co-authored-by: Irene Blanco <[email protected]> Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Dmitrii Shevchenko <[email protected]> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Ania Kowalska <[email protected]> Co-authored-by: Milosz Marcinkowski <[email protected]> Co-authored-by: Sergi Romeu <[email protected]> Co-authored-by: Nathan Reese <[email protected]> Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Viduni Wickramarachchi <[email protected]> Co-authored-by: wajihaparvez <[email protected]>

[Ownership] Assign test files to ml-ui team

591f2f7

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 14, 2024

wayneseymour requested a review from a team November 14, 2024 16:12

wayneseymour self-assigned this Nov 14, 2024

pheyos reviewed Nov 14, 2024

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

drop

9c63452

wayneseymour requested a review from pheyos November 14, 2024 17:04

elasticmachine and others added 2 commits November 14, 2024 18:04

Merge branch 'main' into assign-ml

4376711

[CI] Auto-commit changed files from 'make api-docs'

44e1a68

peteharverson reviewed Nov 18, 2024

View reviewed changes

ghudgins and others added 18 commits November 18, 2024 09:33

[Discover] mailto links in data view urls (elastic#200070)

62e9fe7

Adds `mailto:` as an allowed URL Url formatters in data views.

kbn-expect - add .eql support for sets (elastic#200034)

1384073

## Summary This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.

[Ownership] Assign test files to Appex QA (elastic#199767)

b44af90

## Summary Assign test files to Appex QA Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

[Fleet] Fix OAS snapshot (elastic#200186)

d9f9b10

## Summary Fix OAS snapshot --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

[Discover] fix: set smaller max width for mobile devices (elastic#199798

c8220b4

)

[Ownership] Assign test files to search kibana team (elastic#200013)

0bf9e42

## Summary Assign test files to search kibana team Contributes to: elastic#192979

[presentation-utils] remove defaultTheme$ (elastic#200044)

96b48ba

Closes elastic#200037 defaultTheme$ is only used in storybooks. This PR removes defaultTheme$ and replaces it with theme$ available from core start mock.

[OpenAPI][DOCS] Add descriptions for alerting rule flapping properties (

1ebb244

elastic#200112)

[Docs] Add breaking change to release notes (elastic#200065)

9569091

## Summary Adding a Kibana-related breaking change found in the Security release notes.

[CI] Auto-commit changed files from 'make api-docs'

a4f5595

Merge branch 'assign-ml' of github.com:wayneseymour/kibana into assig…

597440a

…n-ml

re-org

5c597a5

Merge branch 'main' into assign-ml

ab6aca6

wayneseymour requested a review from peteharverson November 18, 2024 09:41

peteharverson approved these changes Nov 18, 2024

View reviewed changes

wayneseymour merged commit 742016a into elastic:main Nov 18, 2024
23 checks passed

kibanamachine added the v9.0.0 label Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ownership] Assign test files to ml-ui team #200212

[Ownership] Assign test files to ml-ui team #200212

wayneseymour commented Nov 14, 2024

wayneseymour commented Nov 14, 2024

peteharverson left a comment

peteharverson Nov 18, 2024

wayneseymour Nov 18, 2024

peteharverson Nov 18, 2024

wayneseymour Nov 18, 2024

peteharverson Nov 18, 2024

wayneseymour Nov 18, 2024

peteharverson Nov 18, 2024

wayneseymour Nov 18, 2024

peteharverson Nov 18, 2024

wayneseymour Nov 18, 2024

wayneseymour commented Nov 18, 2024

peteharverson left a comment

elasticmachine commented Nov 18, 2024

[Ownership] Assign test files to ml-ui team #200212

[Ownership] Assign test files to ml-ui team #200212

Conversation

wayneseymour commented Nov 14, 2024

Summary

wayneseymour commented Nov 14, 2024

peteharverson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wayneseymour commented Nov 18, 2024

peteharverson left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 18, 2024

💚 Build Succeeded

Metrics [docs]

History