[Ownership] Assign test files to presentation team #200209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:fix
backport:skip
|
@elasticmachine merge upstream |
jsanz
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
requested changes
Nov 18, 2024
.github/CODEOWNERS
Outdated
| @@ -1334,7 +1334,27 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai | |||
| ### END Observability Plugins | |||
|
|
|||
| # Presentation | |||
| /x-pack/test/disable_ems @elastic/kibana-presentation | |||
| /test/interpreter_functional/baseline @elastic/kibana-presentation | |||
There was a problem hiding this comment.
This path does not seem to exist.
.github/CODEOWNERS
Outdated
| /test/functional/screenshots/baseline/tsvb_dashboard.png @elastic/kibana-presentation | ||
| /test/functional/screenshots/baseline/dashboard_*.png @elastic/kibana-presentation | ||
| /test/functional/screenshots/baseline/area_chart.png @elastic/kibana-presentation | ||
| /test/functional/page_objects/share_page.ts @elastic/kibana-presentation |
There was a problem hiding this comment.
Suggested change
| /test/functional/page_objects/share_page.ts @elastic/kibana-presentation | |
| /test/functional/page_objects/share_page.ts @elastic/appex-sharedux |
It seems like this might be more applicable to @elastic/appex-sharedux as they currently own the share plugin.
.github/CODEOWNERS
Outdated
| /test/functional/page_objects/dashboard_page* @elastic/kibana-presentation | ||
| /test/functional/firefox/dashboard.config.ts @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | ||
| /test/functional/fixtures/es_archiver/dashboard @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | ||
| /test/api_integration/apis/short_url/**/*.ts @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 |
There was a problem hiding this comment.
Suggested change
| /test/api_integration/apis/short_url/**/*.ts @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | |
| /test/api_integration/apis/short_url/**/*.ts @elastic/appex-sharedux |
This is testing API routes from the share plugin which is owned by @elastic/appex-sharedux, so I would reassign.
.github/CODEOWNERS
Outdated
| /test/functional/firefox/dashboard.config.ts @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | ||
| /test/functional/fixtures/es_archiver/dashboard @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | ||
| /test/api_integration/apis/short_url/**/*.ts @elastic/kibana-presentation # Assigned per: https://github.com/elastic/kibana/issues/15023 | ||
| /test/accessibility/apps/kibana_overview_* @elastic/kibana-presentation |
There was a problem hiding this comment.
Suggested change
| /test/accessibility/apps/kibana_overview_* @elastic/kibana-presentation | |
| /test/accessibility/apps/kibana_overview_* @elastic/appex-sharedux |
This is testing the kibana-overview plugin owned by @elastic/appex-sharedux.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
|
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Assign test files to presentation team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Assign test files to presentation team Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assign test files to presentation team
Contributes to: #192979