[Ownership] Assign test files to visualizations team #200144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
stratoula
reviewed
Nov 14, 2024
.github/CODEOWNERS
Outdated
| @@ -1111,7 +1138,11 @@ src/plugins/discover/public/context_awareness/profile_providers/security @elasti | |||
| /test/api_integration/apis/event_annotations @elastic/kibana-visualizations | |||
| /x-pack/test_serverless/functional/test_suites/common/visualizations/ @elastic/kibana-visualizations | |||
| /x-pack/test_serverless/functional/fixtures/kbn_archiver/lens/ @elastic/kibana-visualizations | |||
| packages/kbn-monaco/src/esql @elastic/kibana-esql | |||
| packages/kbn-monaco/src/esql | |||
There was a problem hiding this comment.
Why did you remove our ownership from here? 🤔
There was a problem hiding this comment.
ahh, mistake! apologies Stratoula!
.github/CODEOWNERS
Outdated
| /x-pack/test/functional/apps/managed_content @elastic/kibana-visualizations | ||
| /test/functional/services/visualizations @elastic/kibana-visualizations | ||
| /test/functional/services/renderable.ts @elastic/kibana-visualizations | ||
| /test/functional/services/inspector.ts @elastic/kibana-visualizations # Assigned per https://github.com/elastic/kibana/pull/28509 |
There was a problem hiding this comment.
The PR you mention is of 2019 😄 Inspector is owned by the presentation team nowadays
There was a problem hiding this comment.
whoops! things have changed since I joined! hahahaa
Thanks Stratoula!
stratoula
reviewed
Nov 14, 2024
stratoula
approved these changes
Nov 14, 2024
mbondyra
approved these changes
Nov 14, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Assign test files to visualizations team Contributes to: elastic#192979 --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Assign test files to visualizations team Contributes to: elastic#192979 --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assign test files to visualizations team
Contributes to: #192979