[Upgrade Assistant] Add confirmation modal before migrating system indices #200117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@sabarasaba Could you please take a look? :) |
sabarasaba
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Hey, thanks for having a look at this @youhonglian! Tested locally and works well, I left few comments for you to have a look. I would also love to see some tests implemented before we merge this.
Edit: There are also few broken tests that need to be looked at.
...ant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
Outdated
Show resolved
Hide resolved
...ant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
Outdated
Show resolved
Hide resolved
...ant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
Outdated
Show resolved
Hide resolved
...ant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
Outdated
Show resolved
Hide resolved
...ant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
Outdated
Show resolved
Hide resolved
sabarasaba
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
@elasticmachine merge upstream |
|
/ci |
|
/ci |
…/overview/migrate_system_indices/migrate_system_indices.tsx Co-authored-by: wajihaparvez <[email protected]>
|
@elasticmachine merge upstream |
|
/ci |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @youhonglian |
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
…dices (elastic#200117) (cherry picked from commit bd576e6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
…tem indices (#200117) (#203085) # Backport This will backport the following commits from `main` to `8.x`: - [[Upgrade Assistant] Add confirmation modal before migrating system indices (#200117)](#200117) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"youhonglian","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T11:54:34Z","message":"[Upgrade Assistant] Add confirmation modal before migrating system indices (#200117)","sha":"bd576e6cef57001692eb79c2befab09ac076714d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Upgrade Assistant","💝community","v9.0.0","backport:prev-minor"],"title":"[Upgrade Assistant] Add confirmation modal before migrating system indices","number":200117,"url":"https://github.com/elastic/kibana/pull/200117","mergeCommit":{"message":"[Upgrade Assistant] Add confirmation modal before migrating system indices (#200117)","sha":"bd576e6cef57001692eb79c2befab09ac076714d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200117","number":200117,"mergeCommit":{"message":"[Upgrade Assistant] Add confirmation modal before migrating system indices (#200117)","sha":"bd576e6cef57001692eb79c2befab09ac076714d"}}]}] BACKPORT--> Co-authored-by: youhonglian <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #199621
In this PR, add a confirmation modal when the migrate indices button is clicked.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_node:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.