Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search][ES3] Enable Inference Management UI in ES3 #200109
[Search][ES3] Enable Inference Management UI in ES3 #200109
Changes from 17 commits
b58d99f
b16064a
aec1441
9f9841c
a244eee
9679312
4a7ec94
86d38d9
d6d570c
690f6db
a33a1c0
43c794a
1ab1d82
83da4ab
4361cb7
41d3620
4b757e1
7cd2d91
505d488
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🙇 Thanks for aligning the stack & serverless URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to this code - mind posting a screenshot that shows the UI affected by this? Also, can you remind me why this conditional is needed and which environments lack the enterprise_search app? I can assume, but you might know better than me and it would be nice to have it directly mentioned in the pr. Actually, the PR description is vague - what was broken and how was it fixed? If this is mentioned in an issue simply linking to it would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mattkime , Thank you for bringing this up. We are releasing
inference management UI
in Serverless (PR title fixed) and hit many small issues that needed fixing.This particular code change required as
Manage Inference Endpoint
in Popover links(please see attached screenshot) were hardcoded and will always redirect to enterprise search -> inference endpoints. However, for Serverless, we want them to redirect to Serverless -> inference endpoints.This is a bit odd as both
enterprise-search
andserverless
render the same plugin into two different URLs. From81.8
, this will change however we need a fix till then.Hope that helps.