Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused rule data client #200080

Closed
wants to merge 4 commits into from

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Nov 13, 2024

Summary

Followup to #192576. RuleDataClient is no longer used by observability rules since they're not using the lifecycle executor so we can remove the initialization logic.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #89 / rules security and spaces enabled: basic Alert - Get feature ids by registration context Users: obs_only_all_spaces_all should be able to get feature id for registration context 'observability.apm' in space1
  • [job] [logs] FTR Configs #89 / rules security and spaces enabled: basic Alert - Get feature ids by registration context Users: obs_only_all_spaces_all should be able to get feature id for registration context 'observability.apm' in space1

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
infra 42 40 -2

Total ESLint disabled count

id before after diff
infra 51 49 -2

History

@ymao1 ymao1 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants