Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Index Mgmt] Improve accessibility of templates table (#199980) #200031

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[8.x] [Index Mgmt] Improve accessibility of templates table (#199980) #200031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 44 additions & 19 deletions ...management/public/application/components/shared/components/template_content_indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,46 +16,71 @@ interface Props {
contentWhenEmpty?: JSX.Element | null;
}

const texts = {
settings: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexSettingsTooltipLabel', {
defaultMessage: 'Index settings',
}),
mappings: i18n.translate('xpack.idxMgmt.templateContentIndicator.mappingsTooltipLabel', {
defaultMessage: 'Mappings',
}),
aliases: i18n.translate('xpack.idxMgmt.templateContentIndicator.aliasesTooltipLabel', {
defaultMessage: 'Aliases',
}),
};
const getColor = (flag: boolean) => (flag ? 'primary' : 'hollow');

export const TemplateContentIndicator = ({
mappings,
settings,
aliases,
contentWhenEmpty = null,
}: Props) => {
const getColor = (flag: boolean) => (flag ? 'primary' : 'hollow');

if (!mappings && !settings && !aliases) {
return contentWhenEmpty;
}

const texts = {
settingsTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexSettingsTrueLabel', {
defaultMessage: 'This template contains index settings',
}),
settingsFalse: i18n.translate(
'xpack.idxMgmt.templateContentIndicator.indexSettingsFalseLabel',
{
defaultMessage: 'This template does not contain index settings',
}
),
mappingsTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexMappingsTrueLabel', {
defaultMessage: 'This template contains index mappings',
}),
mappingsFalse: i18n.translate(
'xpack.idxMgmt.templateContentIndicator.indexMappingsFalseLabel',
{
defaultMessage: 'This template does not contain index mappings',
}
),
aliasesTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexAliasesTrueLabel', {
defaultMessage: 'This template contains index aliases',
}),
aliasesFalse: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexAliasesFalseLabel', {
defaultMessage: 'This template does not contain index aliases',
}),
};

const mappingsText = mappings ? texts.mappingsTrue : texts.mappingsFalse;
const settingsText = settings ? texts.settingsTrue : texts.settingsFalse;
const aliasesText = aliases ? texts.aliasesTrue : texts.aliasesFalse;

return (
<>
<EuiToolTip content={texts.mappings}>
<EuiToolTip content={mappingsText}>
<>
<EuiBadge color={getColor(mappings)}>M</EuiBadge>
<EuiBadge color={getColor(mappings)} aria-label={mappingsText}>
M
</EuiBadge>
&nbsp;
</>
</EuiToolTip>
<EuiToolTip content={texts.settings}>
<EuiToolTip content={settingsText}>
<>
<EuiBadge color={getColor(settings)}>S</EuiBadge>
<EuiBadge color={getColor(settings)} aria-label={settingsText}>
S
</EuiBadge>
&nbsp;
</>
</EuiToolTip>
<EuiToolTip content={texts.aliases}>
<EuiBadge color={getColor(aliases)}>A</EuiBadge>
<EuiToolTip content={aliasesText}>
<EuiBadge color={getColor(aliases)} aria-label={aliasesText}>
A
</EuiBadge>
</EuiToolTip>
</>
);
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23539,9 +23539,6 @@
"xpack.idxMgmt.templateBadgeType.cloudManaged": "Géré dans le cloud",
"xpack.idxMgmt.templateBadgeType.managed": "Géré",
"xpack.idxMgmt.templateBadgeType.system": "Système",
"xpack.idxMgmt.templateContentIndicator.aliasesTooltipLabel": "Alias",
"xpack.idxMgmt.templateContentIndicator.indexSettingsTooltipLabel": "Paramètres des index",
"xpack.idxMgmt.templateContentIndicator.mappingsTooltipLabel": "Mappings",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneDescription": "Chargement du modèle à cloner en cours…",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneErrorMessage": "Erreur lors du chargement du modèle à cloner",
"xpack.idxMgmt.templateDetails.aliasesTabTitle": "Alias",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23510,9 +23510,6 @@
"xpack.idxMgmt.templateBadgeType.cloudManaged": "クラウド管理",
"xpack.idxMgmt.templateBadgeType.managed": "管理中",
"xpack.idxMgmt.templateBadgeType.system": "システム",
"xpack.idxMgmt.templateContentIndicator.aliasesTooltipLabel": "エイリアス",
"xpack.idxMgmt.templateContentIndicator.indexSettingsTooltipLabel": "インデックス設定",
"xpack.idxMgmt.templateContentIndicator.mappingsTooltipLabel": "マッピング",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneDescription": "クローンを作成するテンプレートを読み込み中…",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneErrorMessage": "クローンを作成するテンプレートを読み込み中にエラーが発生",
"xpack.idxMgmt.templateDetails.aliasesTabTitle": "エイリアス",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23563,9 +23563,6 @@
"xpack.idxMgmt.templateBadgeType.cloudManaged": "云托管",
"xpack.idxMgmt.templateBadgeType.managed": "托管",
"xpack.idxMgmt.templateBadgeType.system": "系统",
"xpack.idxMgmt.templateContentIndicator.aliasesTooltipLabel": "别名",
"xpack.idxMgmt.templateContentIndicator.indexSettingsTooltipLabel": "索引设置",
"xpack.idxMgmt.templateContentIndicator.mappingsTooltipLabel": "映射",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneDescription": "正在加载要克隆的模板……",
"xpack.idxMgmt.templateCreate.loadingTemplateToCloneErrorMessage": "加载要克隆的模板时出错",
"xpack.idxMgmt.templateDetails.aliasesTabTitle": "别名",
Expand Down