Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: [Search:WebCrawlers:ViewCrawler:Manage Domains page]Incorrect total number of options announced for Policy and Rules combo box (#199745) #200003

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

kibanamachine
Copy link
Contributor

…tal number of options announced for Policy and Rules combo box (elastic#199745)

Closes: elastic#199132

## Description
Visible total number of options should the same as announced for the
user as not to confuse them. Especially for the users using assistive
technologies.

## What was changed:
1. value of `hasNoInitialSelection` attribute value has been updated for
the mentioned cases. This removes the extra selection option from the
DOM and fixes the `a11y` issue.

## Screen:

<img width="1201" alt="image"
src="https://github.com/user-attachments/assets/6cf3dc6f-8664-44a9-baa8-453764098ad9">

(cherry picked from commit e967193)
@kibanamachine kibanamachine merged commit 82117f1 into elastic:8.x Nov 13, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / saved objects tagging - functional tests visualize integration editing allows to assign tags to an existing visualization

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +452.0B

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants