Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [OAS][Docs] Use correct bump dependency in makefile (#199876) #200001

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[8.x] [OAS][Docs] Use correct bump dependency in makefile (#199876) #200001

merged 1 commit into from
Nov 13, 2024

Conversation

nickpeihl
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nickpeihl
[OAS][Docs] Use correct bump dependency in makefile (elastic#199876)
881efd5 
## Summary

Updates the Open API docs make targets to use the correct bump.sh
dependency.

Unless I'm missing something obvious in my local configuration, `@npx
bump ...` uses [node-bump](https://www.npmjs.com/package/bump) not the
[bump.sh library](https://www.npmjs.com/package/bump-cli). I discovered
this while trying to run the make targets locally.

(cherry picked from commit fcc9392)

# Conflicts:
#	oas_docs/makefile
@nickpeihl nickpeihl enabled auto-merge (squash) November 13, 2024 13:31
@nickpeihl nickpeihl mentioned this pull request Nov 13, 2024
Merged
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #70 / APM API tests transactions/transactions_groups_alerts.spec.ts basic no archive when data is loaded Alerts Transaction groups with avg transaction duration alerts returns the correct number of alert counts
  • [job] [logs] FTR Configs #81 / ObservabilityApp feature controls observability security feature controls no observability privileges "after all" hook for "create new case returns a 403"
  • [job] [logs] FTR Configs #81 / ObservabilityApp feature controls observability security feature controls no observability privileges "before all" hook for "returns a 403"

Metrics [docs]

✅ unchanged

@nickpeihl nickpeihl merged commit 56c8fd1 into elastic:8.x Nov 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpeihl @elasticmachine @lcawl