[8.16] [EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071) #199992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicate values with the 'is one of' operator on Blocklist tab (elastic#196071) These changes ensure that the warning displayed to the user for duplicate values remains visible after onBlur. I’ve opted to keep it as a warning rather than an error since entering a duplicate value doesn’t allow the user to “save” it as a selected item in the combo box—it remains an active string in the input field. We don’t block form submission due to this warning; any unselected value in the combo box is stripped out. The red border on the combo box is part of EUI’s behavior when attempting to select a duplicate, and I don’t see an easy way to modify this at the moment. https://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098 (cherry picked from commit 99a19e7)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pzl
approved these changes
Nov 13, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2024
…27; shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071) (#200915) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071)](#196071) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T10:29:32Z","message":"[EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071)\n\nThese changes ensure that the warning displayed to the user for\r\nduplicate values remains visible after onBlur. I’ve opted to keep it as\r\na warning rather than an error since entering a duplicate value doesn’t\r\nallow the user to “save” it as a selected item in the combo box—it\r\nremains an active string in the input field. We don’t block form\r\nsubmission due to this warning; any unselected value in the combo box is\r\nstripped out. The red border on the combo box is part of EUI’s behavior\r\nwhen attempting to select a duplicate, and I don’t see an easy way to\r\nmodify this at the moment.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098","sha":"99a19e762daf08376828032e593a9e88befe6d23","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","backport:version","v8.17.0","v8.16.1"],"title":"[EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab","number":196071,"url":"https://github.com/elastic/kibana/pull/196071","mergeCommit":{"message":"[EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071)\n\nThese changes ensure that the warning displayed to the user for\r\nduplicate values remains visible after onBlur. I’ve opted to keep it as\r\na warning rather than an error since entering a duplicate value doesn’t\r\nallow the user to “save” it as a selected item in the combo box—it\r\nremains an active string in the input field. We don’t block form\r\nsubmission due to this warning; any unselected value in the combo box is\r\nstripped out. The red border on the combo box is part of EUI’s behavior\r\nwhen attempting to select a duplicate, and I don’t see an easy way to\r\nmodify this at the moment.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098","sha":"99a19e762daf08376828032e593a9e88befe6d23"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196071","number":196071,"mergeCommit":{"message":"[EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071)\n\nThese changes ensure that the warning displayed to the user for\r\nduplicate values remains visible after onBlur. I’ve opted to keep it as\r\na warning rather than an error since entering a duplicate value doesn’t\r\nallow the user to “save” it as a selected item in the combo box—it\r\nremains an active string in the input field. We don’t block form\r\nsubmission due to this warning; any unselected value in the combo box is\r\nstripped out. The red border on the combo box is part of EUI’s behavior\r\nwhen attempting to select a duplicate, and I don’t see an easy way to\r\nmodify this at the moment.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098","sha":"99a19e762daf08376828032e593a9e88befe6d23"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/199992","number":199992,"state":"MERGED","mergeCommit":{"sha":"4c5d5fa5a40014b0d8b09d0a9d07b7a7eec899a1","message":"[8.16] [EDR Workflows] Error message 'the value already exists' shown for duplicate values with the 'is one of' operator on Blocklist tab (#196071) (#199992)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[EDR Workflows] Error message 'the value already exists'\nshown for duplicate values with the 'is one of' operator on\nBlocklist tab (#196071)](https://github.com/elastic/kibana/pull/196071)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Konrad\nSzwarc\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-23T10:29:32Z\",\"message\":\"[EDR\nWorkflows] Error message 'the value already exists' shown for duplicate\nvalues with the 'is one of' operator on Blocklist tab (#196071)\\n\\nThese\nchanges ensure that the warning displayed to the user for\\r\\nduplicate\nvalues remains visible after onBlur. I’ve opted to keep it as\\r\\na\nwarning rather than an error since entering a duplicate value\ndoesn’t\\r\\nallow the user to “save” it as a selected item in the combo\nbox—it\\r\\nremains an active string in the input field. We don’t block\nform\\r\\nsubmission due to this warning; any unselected value in the\ncombo box is\\r\\nstripped out. The red border on the combo box is part of\nEUI’s behavior\\r\\nwhen attempting to select a duplicate, and I don’t see\nan easy way to\\r\\nmodify this at the\nmoment.\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098\",\"sha\":\"99a19e762daf08376828032e593a9e88befe6d23\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport\nmissing\",\"v9.0.0\",\"Team:Defend\nWorkflows\",\"backport:version\",\"v8.16.1\"],\"title\":\"[EDR Workflows] Error\nmessage 'the value already exists' shown for duplicate values with the\n'is one of' operator on Blocklist\ntab\",\"number\":196071,\"url\":\"https://github.com/elastic/kibana/pull/196071\",\"mergeCommit\":{\"message\":\"[EDR\nWorkflows] Error message 'the value already exists' shown for duplicate\nvalues with the 'is one of' operator on Blocklist tab (#196071)\\n\\nThese\nchanges ensure that the warning displayed to the user for\\r\\nduplicate\nvalues remains visible after onBlur. I’ve opted to keep it as\\r\\na\nwarning rather than an error since entering a duplicate value\ndoesn’t\\r\\nallow the user to “save” it as a selected item in the combo\nbox—it\\r\\nremains an active string in the input field. We don’t block\nform\\r\\nsubmission due to this warning; any unselected value in the\ncombo box is\\r\\nstripped out. The red border on the combo box is part of\nEUI’s behavior\\r\\nwhen attempting to select a duplicate, and I don’t see\nan easy way to\\r\\nmodify this at the\nmoment.\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098\",\"sha\":\"99a19e762daf08376828032e593a9e88befe6d23\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196071\",\"number\":196071,\"mergeCommit\":{\"message\":\"[EDR\nWorkflows] Error message 'the value already exists' shown for duplicate\nvalues with the 'is one of' operator on Blocklist tab (#196071)\\n\\nThese\nchanges ensure that the warning displayed to the user for\\r\\nduplicate\nvalues remains visible after onBlur. I’ve opted to keep it as\\r\\na\nwarning rather than an error since entering a duplicate value\ndoesn’t\\r\\nallow the user to “save” it as a selected item in the combo\nbox—it\\r\\nremains an active string in the input field. We don’t block\nform\\r\\nsubmission due to this warning; any unselected value in the\ncombo box is\\r\\nstripped out. The red border on the combo box is part of\nEUI’s behavior\\r\\nwhen attempting to select a duplicate, and I don’t see\nan easy way to\\r\\nmodify this at the\nmoment.\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/84b6d8af-02a8-41f3-88dc-892ed408a098\",\"sha\":\"99a19e762daf08376828032e593a9e88befe6d23\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.1\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Konrad Szwarc <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation